From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qmta12.emeryville.ca.mail.comcast.net (qmta12.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:44:76:96:27:227]) by hurricane.the-brannons.com (Postfix) with ESMTP id 2203477B1A for ; Fri, 12 Sep 2014 14:13:18 -0700 (PDT) Received: from omta13.emeryville.ca.mail.comcast.net ([76.96.30.52]) by qmta12.emeryville.ca.mail.comcast.net with comcast id qKXE1o00117UAYk01MBd2N; Fri, 12 Sep 2014 21:11:37 +0000 Received: from eklhad ([IPv6:2601:4:5380:4ee:21e:4fff:fec2:a0f1]) by omta13.emeryville.ca.mail.comcast.net with comcast id qMBc1o00P5LMg218ZMBdsA; Fri, 12 Sep 2014 21:11:37 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke User-Agent: edbrowse/3.5.1 Date: Fri, 12 Sep 2014 17:10:32 -0400 Message-ID: <20140812171032.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1410556297; bh=cvGqJGzxCpCp6BF/NTCX6nvkf0tDeWVk5cyuxC/h+LQ=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=EZSO2sUmWGClZqXZ+VAosHO21MvgOcZthKj1scsxqA6J1qJaLRox6UZgr8JZsSwjs U4/XlDIvt+rS0Bw4rELdOq4QXQn25vOaiqFm/0278yrClfwAeKf+MSdyWVa1/nZZQv Km7krDVM4+COe2iLzYJ9eKpQqIPG1hBYVQ6wXBHuA9grJ58lbV66DlOKX1n1a00I8p gV4mku6slpNscfwe/7yJ6k8AR9LQD/NMJZNKfkXTVk0u4n1qMPk+AsVhG4vdry0TOb XFCVFunh5597ozjMzVUcP/QkRZY7um0cFmE0dIu4jhiIRA/GkVriaDLzam9Hbt8d5q 8GeOraIm9W4zQ== Subject: [Edbrowse-dev] [PATCH] Implement the "novs" directive. X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Sep 2014 21:13:18 -0000 This looks good. You could submit it and I would be fine with that. I do have a couple small questions though. The first is just style / consistency. You use strcasecmp for I guess string compare case insensitive. A library function I didn't know about? I use throughout stringEqualCI, which I wrote myself. Should we always use one, or the other? Mine is part of a suite of such CI functions, like mem compare CI and so on, I'm sure not all have library equivalents. You took the time to add sites in a growing dynamic list, which is right, sometimes I was too lazy to do that. Like nojs, I store 100 sites for no javascript and that's it. Any time you, or I, feel like making this dynamic, feel free. Same for email accounts, though I can't imagine anyone having more than 100 of those. And maybe other static lists floating around. When you check for novs match you need an exact match. Not so for nojs. whatever.com will also have no javascript for subdomains like foo.whatever.com. See the code in main.c that does that. Should we do the same for novs? I would think so; if there's no cert for whatever.com then there is for sure no cert for foo.whatever.com. Karl Dahlke