Re: [Edbrowse-dev] wordexp

[Adam Thompson <arthompson1990@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

On Tue, Dec 30, 2014 at 06:10:49AM -0500, Karl Dahlke wrote:
> After considerable waffling, I decided to give wordexp a try
> for variable expansion and globbing on file names.
> Odds are, we won't notice any difference.
> But at least it is somewhat standard now, and I got rid of a bunch of
> #ifdef Windows dos unix code.
> Some of the old code is still in there under #if 0,
> and I'll get rid of that when I have confidence in the new system.

Ok, everything appears to work ok, though I pushed a change to allow expansion of env variables etc for non-existant file names when writing or setting the file name.
For example:
export tmpdir=/tmp
then:
edbrowse
f $tmpdir/test.txt
w $tmpdir/test_2.txt

Now allows you to set the file name to /tmp/test.txt and write to /tmp/test_2.txt
rather than erroring as it did previously.
Note that, if the file doesn't exist, b,
r and e commands still error as expected.

> Speaking of old stuff, we'll have to decide when to delete
> jsdom.cpp jsloc.cpp js.h.
> That is, when are we committed to the new system?
> Of course, thanks to git, you never really delete stuff,
> you can always get it back if you want it.

Thus I'd say delete it now, since it appears to work just as well as the
previous system.

Cheers,
Adam.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]