From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [IPv6:2a00:1450:400c:c00::22c]) by hurricane.the-brannons.com (Postfix) with ESMTPS id AE9BA78F46 for ; Tue, 13 Jan 2015 15:37:18 -0800 (PST) Received: by mail-wg0-f44.google.com with SMTP id y19so5896547wgg.3 for ; Tue, 13 Jan 2015 15:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=T58ISEMilWst0qJUFLOOEuwNMhl5y6ZP2UCwsB7e3gQ=; b=JVW2AH/J7PN8dZFxi2fUIYEfIPLM4rF8hNd8fn6syNV4D83cUuGSOvGbQu8UBavtJr Pc5JXUErSrFSPgNP4/BTaXwhkXZWIgg4mYg2NyZQgk+LcKStU7lQcKLi8qWLeTLinqB0 fUvxKMN6I2fUWj4sOAGVmq9HedG6U32iPRyaJq00OYexha+q9d4NgWzMKAnCUGyR5nhA T3+iG/uGR0caeWUY/3trFFX/K5eg1VsQvqvIuDVoHeMLIUJvI8HlhiEDblWXlfEtW0XR 5wYhjYLZJiD3BGuLneRTEiheZ6hffFBaODFqH/29U3FhEi2oyO/wUobP433srPEtuy3r 0AXQ== X-Received: by 10.194.2.34 with SMTP id 2mr1750058wjr.58.1421192080855; Tue, 13 Jan 2015 15:34:40 -0800 (PST) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by mx.google.com with ESMTPSA id uq1sm27602029wjc.14.2015.01.13.15.34.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Jan 2015 15:34:40 -0800 (PST) Date: Tue, 13 Jan 2015 23:34:38 +0000 From: Adam Thompson To: Karl Dahlke Message-ID: <20150113233438.GM31364@toaster.adamthompson.me.uk> References: <20150013161052.eklhad@comcast.net> <20150113232118.GL31364@toaster.adamthompson.me.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FxlYARId5dseejUu" Content-Disposition: inline In-Reply-To: <20150113232118.GL31364@toaster.adamthompson.me.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Edbrowse-dev@lists.the-brannons.com Subject: Re: [Edbrowse-dev] startwindow.js changes X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jan 2015 23:37:19 -0000 --FxlYARId5dseejUu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 13, 2015 at 11:21:18PM +0000, Adam Thompson wrote: > On Tue, Jan 13, 2015 at 04:10:52PM -0500, Karl Dahlke wrote: > > Well it did break something in jsrt, though small. > >=20 > > You removed the lines that link the new elements into the arrays > > of said elements, and honestly I don't know what the correct behavior i= s here. > > When I create a script, should it be in the list of scripts? > > I don't know. > > The last function document.script$$pending() assumes that a script crea= ted > > will be in this list, and then looks through this list for scripts pend= ing, > > for a script to run that hasn't been run. > > If a created script should not be put on the list document.scripts, > > then we have to put this one somewhere, in some kind of queue, > > so it can be run. > >=20 > > jsrt exercised this feature by creating one final script which, when ru= n, > > put one line at the end of jsrt.browse. > > The line use to say {Last Link}. > > That line is not there any more, because the last script never runs, > > because it is not placed in document.scripts. > > We may need to do a little research to see how it *should* behave. > > Either these elements get put in their corresponding lists automaticall= y, > > or if not then we need to implement a run queue for created scripts. Ok, as a temporary fix, I've implemented document.script$$queue, where scripts are pushed (like they used to be with document.scripts) upon = creation. This fixes the jsrt test at least. Though, looking at how you're supposed to create elements with js, this test looks broken in that it assumes a script is going to be ran which= is never explicitly inserted into the DOM (createElement does just that, creates a DOM object). Cheers, Adam. --FxlYARId5dseejUu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUtauOAAoJELZ22lNQBzHOAVUH/24zqXP4tB6XdjYhzSpox6km seEYODgTX7J+sQLAFTPIpbTPby40zl0rpEepACX3DZGDzZMO8+DX0yGs4pWM6MSZ KArr5dgJUEbL1HifWRuFhip6L6v24pwf74C6oOEmiyRIeeOKl4BQYE0VQNZ201QT DaASltC02vmJzDOOwKrA6YCSZIGPUj1RnG3bF6F0ItdgcuuWuox237csWb3c3MyK w+Tz7th0CZtzX7hJ2yFpEF+eIxIBDY8i5iI0bIt6s1koaFCzLuQeEGH1aRUzO+cM TaZBD5W7jqZEmCm1dOQqU68cuK/w9LANFy8XTGuXBsjP9eSVBpd+mfdNtNLvY44= =ihtz -----END PGP SIGNATURE----- --FxlYARId5dseejUu--