edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] pdf auto download
Date: Fri, 27 Mar 2015 23:42:33 -0400	[thread overview]
Message-ID: <20150227234233.eklhad@comcast.net> (raw)

An unexpected side effect of our recent download to disk feature
is that it takes place on pdf files,
and I really don't want it to.
Here is the logic, when surfing the web.
If the http headers say the file that is coming is text,
it is loaded into memory and rendered.
You still have the option to save it to disk,
formatted or unformatted, but it doesn't go down that path automatically,
because it's most likely a web page that you just want to read.
I think a pdf file should be treated the same way, though it is not today,
because its content type is application/pdf.
I propose adding, somewhere near http.c line 1568,
the additional check for application/pdf, so it is treated like other
text/html files, like other web pages.
Passing the idea by you first, before I make the change.

             reply	other threads:[~2015-03-28  3:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-28  3:42 Karl Dahlke [this message]
2015-03-28 10:03 ` Chuck Hallenbeck
2015-03-28 12:13 ` Chris Brannon
2015-03-28 11:18 Karl Dahlke
2015-04-07 17:43 ` Adam Thompson
2015-04-07 18:23 Karl Dahlke
2015-04-10 11:22 ` Adam Thompson
2015-04-10 11:48 Karl Dahlke
2015-04-10 13:58 ` Adam Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227234233.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).