From: Karl Dahlke <eklhad@comcast.net>
To: edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] directory mode and broken symlinks
Date: Thu, 23 Apr 2015 03:51:22 -0400 [thread overview]
Message-ID: <20150323035122.eklhad@comcast.net> (raw)
In-Reply-To: <553841AE.4060707@pcdesk.net>
Ok - I went back to opendir readder etc and it fixes your bug,
broken symlinks now appear.
And it's less code than setting up for glob().
I still need glob for expanding wildcards in filenames.
No mistake about that.
My home grown version wasn't very good.
It only expanded wildcards at the end, not the middle of the path.
So I'm glad we did this work, but as for a simple directory scan,
as Adam pointed out, glob is overkill -
and it did introduce at least one small bug.
With the scan back under our control, the sort is also under our control.
I use strcmp because it's easy, but should I be using strcoll?
In other words, should the sort always be ascii coalating,
or should the user be able to control it through his LC variables?
Maybe in an ideal world it should run like ls, however that sorts,
and maybe that's what strcoll would do, I'm not sure.
Karl Dahlke
next prev parent reply other threads:[~2015-04-23 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 0:49 Tyler Spivey
2015-04-23 1:09 ` Karl Dahlke
2015-04-23 2:09 ` Karl Dahlke
2015-04-23 7:51 ` Karl Dahlke [this message]
2015-04-26 13:10 ` Adam Thompson
2015-04-27 20:02 ` Karl Dahlke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323035122.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).