From: Adam Thompson <arthompson1990@gmail.com>
To: Karl Dahlke <eklhad@comcast.net>
Cc: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] mailx, plugin commands, mime, new sourcefile
Date: Tue, 14 Apr 2015 07:49:38 +0100 [thread overview]
Message-ID: <20150414064938.GJ9150@toaster.adamthompson.me.uk> (raw)
In-Reply-To: <20150313163357.eklhad@comcast.net>
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
On Mon, Apr 13, 2015 at 04:33:57PM -0400, Karl Dahlke wrote:
> > but I'd like it if the type attribute was optional
>
> I was looking at this stuff and asked myself, "what the hell is type for?"
> It is used nowhere, except one place, where the string
> is copied into a mime object in the js world.
> There is such an object for each mime entity in the config file.
> That object wants a type attribute, I don't know what for.
> We could probably do without it just fine,
> or maybe just copy the description in there.
I'd probably put the content type in there actually since that seems the most
logical thing to go into the type attribute of a mime object to me.
If this is unspecified then just don't create a mime object for that plugin.
> > I'd also probably rename this as plugin since it's now more than just mime type handlers.
>
> I think that's a great idea, will probably do that
> unless someone objects.
> Not sure if I will retroactively change all the variables in the source code,
> but at least the config file syntax.
Thanks, I think the variables can be altered either now or later depending on
how these plugins are used in a given context, e.g.
in some situations the mime naming may make sense.
> > Should this be plugin.c rather than mime.c?
>
> Yes I think so, I'll do a git rename soon.
> That's easy. Thanks.
As well as altering the Makefiles etc.
Cheers,
Adam.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-04-14 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 16:00 [Edbrowse-dev] mailx Karl Dahlke
2015-04-12 19:36 ` Adam Thompson
2015-04-12 20:46 ` [Edbrowse-dev] mailx, plugin commands, mime, new sourcefile Karl Dahlke
2015-04-13 20:16 ` Adam Thompson
2015-04-13 20:33 ` Karl Dahlke
2015-04-14 6:49 ` Adam Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414064938.GJ9150@toaster.adamthompson.me.uk \
--to=arthompson1990@gmail.com \
--cc=Edbrowse-dev@lists.the-brannons.com \
--cc=eklhad@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).