From: Adam Thompson <arthompson1990@gmail.com>
To: Karl Dahlke <eklhad@comcast.net>
Cc: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] wordexp again
Date: Fri, 17 Apr 2015 08:12:43 +0100 [thread overview]
Message-ID: <20150417071243.GB5949@toaster.adamthompson.me.uk> (raw)
In-Reply-To: <20150316174053.eklhad@comcast.net>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Thu, Apr 16, 2015 at 05:40:53PM -0400, Karl Dahlke wrote:
> I made one common routine to protect a file name or directory name from
> shell expansion, it's the same code I was using before, but now it is shared
> between the directory scan and the plugin commands.
> Ok, that's good software practice, but it exposed a bug
> that I think was there all along.
> You can't edit a directory with a backslash in it.
>
> mkdir "a\\b"
> cd a?b
> touch foo bar
> cd ..
> edbrowse a?b
>
> Try it before or after my latest push.
> The files therein just don't show up,
> because wordexp doesn't expand a\\b/* properly.
> and that is the proper escaping.
> At the shell prompt
> ls a\\b/*
> works fine.
> And it all works through the plugin system, i.e. a\b.pdf becomes
> pdftohtml a\\b.pdf
> This seems to be a bug in wordexp, at least my wordexp,
> and I'm really not sure what to do about it.
I can reproduce it, but I wasn't aware we were passing these to wordexp.
I'll look into this if you want.
Cheers,
Adam.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-17 7:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 21:40 Karl Dahlke
2015-04-17 7:12 ` Adam Thompson [this message]
2015-04-17 12:50 ` Adam Thompson
2015-04-17 13:33 ` Karl Dahlke
2015-04-17 17:59 ` Adam Thompson
2015-04-17 13:47 ` Karl Dahlke
2015-04-17 18:01 ` Karl Dahlke
2015-04-17 21:34 ` Adam Thompson
2015-04-17 21:58 ` Adam Thompson
2015-04-17 22:25 ` Karl Dahlke
2015-04-17 22:43 ` Adam Thompson
2015-04-17 23:14 ` Karl Dahlke
2015-04-17 22:28 ` Adam Thompson
2015-04-17 22:39 ` Karl Dahlke
2015-04-18 10:53 ` Adam Thompson
2015-04-18 4:18 ` Karl Dahlke
2015-04-18 10:49 ` Adam Thompson
2015-04-18 11:34 ` Karl Dahlke
2015-04-18 13:09 ` Adam Thompson
2015-04-18 19:33 ` Chris Brannon
2015-04-18 20:05 ` Adam Thompson
2015-04-18 23:03 ` Chris Brannon
2015-04-18 12:36 ` Karl Dahlke
2015-04-18 12:54 ` Adam Thompson
2015-04-18 13:09 ` Karl Dahlke
2015-04-18 13:24 ` Adam Thompson
2015-04-18 13:45 ` Karl Dahlke
2015-04-18 17:44 ` Adam Thompson
2015-04-18 19:48 ` Karl Dahlke
-- strict thread matches above, loose matches on Subject: below --
2015-01-09 22:44 Karl Dahlke
2015-01-09 22:19 Karl Dahlke
2015-01-09 22:29 ` Chris Brannon
2015-01-09 21:16 Chris Brannon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417071243.GB5949@toaster.adamthompson.me.uk \
--to=arthompson1990@gmail.com \
--cc=Edbrowse-dev@lists.the-brannons.com \
--cc=eklhad@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).