From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-x22a.google.com (mail-wg0-x22a.google.com [IPv6:2a00:1450:400c:c00::22a]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 368277AEE7 for ; Fri, 17 Apr 2015 11:00:11 -0700 (PDT) Received: by wgso17 with SMTP id o17so121237678wgs.1 for ; Fri, 17 Apr 2015 10:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=90wn1Ot+p8Iw5NIlMwFGnX5sx+Dbz98rG+iNQJK1/tg=; b=GLROFs8owled7EgeIkj++Zmyqdcpzig1/qoeJFWPrLQMnVB64EbsI/Qs/Yvp9nE5Pj TDnIOlhvHHILNJyBDD+2rU2k5tHvZ5JDhs7GYIm3WU5FSyABsCqz31ZsCFaqTATlx7Qt Bvy+M6yTAP+ms01BnrZ0C1HDxgH7rjpYDK2mTR2HOjhE4wMLtw+L7Kx6W6NdnhXKgLsv 9ZoUq8wjp5AN0mui5U0HxnQinFRmdMgT0xbjMWma6AXlt34LJ0e68kMjFNg+ipO2VHzk 2Mn80P9ACERraSJu08apDadxirBFd0Sv4Z0GGxRun+4jCrE75DEiCpoLjMyppUiUp95W W4Eg== X-Received: by 10.194.109.9 with SMTP id ho9mr8091129wjb.29.1429293546251; Fri, 17 Apr 2015 10:59:06 -0700 (PDT) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by mx.google.com with ESMTPSA id e2sm3611324wij.5.2015.04.17.10.59.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Apr 2015 10:59:05 -0700 (PDT) Date: Fri, 17 Apr 2015 18:59:03 +0100 From: Adam Thompson To: Karl Dahlke Message-ID: <20150417175903.GC5949@toaster.adamthompson.me.uk> References: <20150316174053.eklhad@comcast.net> <20150417125002.GA14517@toaster.adamthompson.me.uk> <20150317093311.eklhad@comcast.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1SQmhf2mF2YjsYvc" Content-Disposition: inline In-Reply-To: <20150317093311.eklhad@comcast.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Edbrowse-dev@lists.the-brannons.com Subject: Re: [Edbrowse-dev] wordexp again X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 18:00:11 -0000 --1SQmhf2mF2YjsYvc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 17, 2015 at 09:33:11AM -0400, Karl Dahlke wrote: > > Basically the "quick check" in envFile is just wrong and needs to go si= nce it >=20 > And yet, I feel like this check was doing something from the user's persp= ective. > Like maybe edbrowse only tries to expand a filename through the shell > if you really intended that it do that. > So it wouldn't try to expand just because the file had a parenthesis or s= ome such. > Maybe that doesn't matter IDK. > And is this really involved at all in the directory backslash bug that st= arted this thread? Yep, removed it and the bug went away. I've pushed the fix as is since I think that most of the time it'll do what= we expect. The way I look at it, if you use the command line with file names with spec= ial chars in them you probably have to escape them anyway. This way we get a consistant behaviour rather than broken shell expansions = and=20 other oddness. I still need to do the readline tab completion fix, that's a little more di= fficult. Cheers, Adam. --1SQmhf2mF2YjsYvc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVMUnnAAoJELZ22lNQBzHOwCAH/j1dY62gqiJ5rlKlx3ezBles gBBbT7gBF7qY/cyS/oWtx+JNrSMBy8dD1EiegqJBd+Au8n14NNmsa/t9MMxBsS/F clecguPh7LdDNqFm1ahnXzI9KuKbNZykXQMdYJzlF6VskiM1/RaH977QmTX8x4RP PAAOk2hdzE8LcrE5bpoSZUnQY7RkMUqtKssmSN/k9eudrtfEB10/fk1kL/STHgzt gGpZUdFyQPNrkitUT/u04hqV7G7qGGvYpJzRNIhht2ricgqilgPjk5I5Cu2Vh/WO pa8ROlknJqqNqlatKQZGpRi95BM5B/T+ys5Puh8FNRUflLo2hDHivjTxG9U1Ljg= =jZfq -----END PGP SIGNATURE----- --1SQmhf2mF2YjsYvc--