Re: [Edbrowse-dev] wordexp again

[Adam Thompson <arthompson1990@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

On Fri, Apr 17, 2015 at 10:34:05PM +0100, Adam Thompson wrote:
> > By the way, removing quick check had nothing to do with the bug
> > that I posted at the top of this thread.
> > You stil can't edit a directory with backslash in the name,
> > and I think that is a bug in wordexp that we can't get around.
> > That's maybe another reason to go back to my home grown code.

No, it's a bug in our code. I've checked and we've got a couple of interesting
things happening. With wordexp enabled, we're duble expanding the filename,
once before we pass it to sortedDirList, and once in nextScanFile.
Without wordexp expansion, we don't expand the file name before we get to
nextScanFile, but then the single \ is swallowed by wordexp so the glob is incorrect.
I should've spotted this when we first switched to using wordexp because the
call in nextScanFile really should be to glob rather than wordexp.
Better still, I think we just shouldn't have switched nextScanFile to wordexp
since we just want a directory listing in this case.

I've also tried out the inverted ` character and that seems to make much more
sense in terms of usable behaviour.

Cheers,
Adam.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]