From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com [IPv6:2a00:1450:400c:c05::231]) by hurricane.the-brannons.com (Postfix) with ESMTPS id AF1347AF06 for ; Sat, 18 Apr 2015 10:45:19 -0700 (PDT) Received: by wicmx19 with SMTP id mx19so10665761wic.1 for ; Sat, 18 Apr 2015 10:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=2v69TMnPttaR/fQPZ4EyR8hz6n0osqXJy9w+07D+rww=; b=tgSSZuIgKevgAJuQfHGmmUE0q0nP7DO4nIPDMt+nnvY6YHSJ6QRJyll/nYOBoIkQoO 93/MIlz433zhE9EQ1D0aLZP55hqYpP1cEwjT4ElGa1+qVNuhFIS+oe9nYCJujvYXM76W JmmPloohXsiWLA2I7PcMiRb4qFuTwfoiynU5V1B83bboR+qyeqx1uCnrh346ecgqp8qv xKbUYRAXxfZkhDNXiuy+gQnPlOXeYKj/ArMg/4DHeIKm5rwM2GNNGhh4jRWJV5dbbIoL sJgYjWkkhcemZ+RhqzZ19hV+0cEu6JS6TC69MO+bda2u1zvaMkuz7gJN8ir8SwJbGjkb yDcg== X-Received: by 10.194.95.132 with SMTP id dk4mr16725961wjb.88.1429379053253; Sat, 18 Apr 2015 10:44:13 -0700 (PDT) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by mx.google.com with ESMTPSA id w5sm7773996wiz.11.2015.04.18.10.44.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Apr 2015 10:44:12 -0700 (PDT) Date: Sat, 18 Apr 2015 18:44:10 +0100 From: Adam Thompson To: Karl Dahlke Message-ID: <20150418174410.GO5949@toaster.adamthompson.me.uk> References: <20150316174053.eklhad@comcast.net> <20150418132406.GN5949@toaster.adamthompson.me.uk> <20150318094559.eklhad@comcast.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5G50dybFf3pRZKd7" Content-Disposition: inline In-Reply-To: <20150318094559.eklhad@comcast.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Edbrowse-dev@lists.the-brannons.com Subject: Re: [Edbrowse-dev] wordexp again X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2015 17:45:20 -0000 --5G50dybFf3pRZKd7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 18, 2015 at 09:45:59AM -0400, Karl Dahlke wrote: > > I think I'd rather clean up the error message and remove the checking t= bh, >=20 > I see where you're coming from. > These are behaviors, and even error messages, that have been this way for= years, > and I'm ok with improving them, I just think I need to move carefully. I'm not so sure careful movement is so required here. The only thing we may break is scripts, and I doubt anyone was a fan of the "shell pattern did not match any files" message in any case. At least this way the message (and code) would be consistant and explanitory. > another message that isn't so great is >=20 > environment variable not defined >=20 > So if you edit $a$b and get this message, > is it a or be that is not defined? > Really, would it have been terribly hard for me > to include the variable in the error message? > Sometimes I wonder what I was thinking 5 or 10 years ago. I think everyone has these moments when looking at old code. I'd like to see this message improved to include the variable though. Cheers, Adam. --5G50dybFf3pRZKd7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVMpfqAAoJELZ22lNQBzHOesUH/0hQf9TBGZ7guhLs7hcAm6wE Vkb6dR01htlLhDBfLawZGZPcpHGPsqovv14df91KiU9PNaQWuNjqoS2f2uhXdvg0 /RRlfBK+FbLSdPjwHNMlCBaQQM8n9PlS5VHLYalYatpAl3mI6YxG5ophppGg274c 7yU9ZdA6/Ar3tmNrSy8C7c0zzUpeka2BbXvJRaW5UAV6v4lMDiB3FzqJLY78vLJL qh6jzcosJ7R7sb/ooTPp5eoeqXcZwP0YLcHRI3N/aVnFUwWkGDlV14tCR6thotHI RNj9ZGKOjNghFyViWxUjtYIbrzpC2jLc8/S2T3E05IqPCqTu7fsF2YmmjHzekhE= =GFGJ -----END PGP SIGNATURE----- --5G50dybFf3pRZKd7--