From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] getters and setters in straight javascript
Date: Sun, 14 Jun 2015 05:11:05 -0400 [thread overview]
Message-ID: <20150514051105.eklhad@comcast.net> (raw)
In-Reply-To: <87y4jn2sqs.fsf@mushroom.localdomain>
Ok - URL setters are now in startwindow.js.
I verified that the setter syntax and invokation etc works in d8,
so I believe it is sufficiently generic.
I traded 400 lines of awkward bug-prone confusing engine-specific C
for 100 lines of plain javascript.
That's another 400 lines you won't have to convert when switching to duktape.
jsrt runs, and it contains a lot of url side effects testing.
I don't think I broke anything.
It may also be worth moving the document.cookie setter out of native C
and into js, though a small part of it must remain native to push
the cookie back to edbrowse and curl and the jar.
I'll be looking at that one over the next couple of days.
Karl Dahlke
next prev parent reply other threads:[~2015-06-14 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 8:48 Karl Dahlke
2015-06-13 10:50 ` Karl Dahlke
2015-06-14 9:13 ` Adam Thompson
2015-06-13 21:39 ` Chris Brannon
2015-06-14 9:11 ` Karl Dahlke [this message]
2015-06-14 9:31 ` Adam Thompson
2015-06-14 15:04 ` Karl Dahlke
2015-06-15 19:59 ` Adam Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514051105.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).