edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev]   getters and setters in straight javascript
Date: Sun, 14 Jun 2015 11:04:21 -0400	[thread overview]
Message-ID: <20150514110421.eklhad@comcast.net> (raw)
In-Reply-To: <20150614093106.GB9965@toaster.adamthompson.me.uk>

It is certainly possible that some of startwindow.js will eventually
have to return to native C,
appendChild and insertBefore in particular, but only if it must.
The advantages of keeping support routines in js are so many and so substantial
I don't even have to list them.
A 4 to 1 code reduction is just one example.

You speak of the day when "we have determined which js engine to use",
as though we will know that the js engine will not need to change again.
I don't have a lot of confidence that day will ever come.
Such things are supported and then not supported.
Even if we do settle on one brand,
mozilla as an example, the next version might
have a completely different api. We've seen that before.
All other things being equal, we would want to minimize
the code that interacts with the js engine.
Call it insurance if you will.

As per the URL setters, these had a lot of c++ strings in them,
which is why I ran into them in the first place.
We were going to have to convert this code back to C strings
if it remained native, so I did an easier conversion,
that may stand or may not.

Yes I agree there isn't much point in moving the document.cookie setter,
it's not that much code, it is straight C, it works,
and some of it has to be native anyways.
The other setters are equally straightforward, and can remain native.

So ok, having removed over 1,000 lines from jseng-moz.cpp,
and having converted the remaining c++ strings to c,
Adam I think we are finally go for launch.
Create jseng-duk.c, and I hope it works, and works well, and works cleanly.
After a small amount of research, Chris is pretty optimistic.
It looks a lot easier to work with than the mozilla beast
we've been wrangling with thus far. But only time will tell.

Karl Dahlke

  reply	other threads:[~2015-06-14 15:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-13  8:48 Karl Dahlke
2015-06-13 10:50 ` Karl Dahlke
2015-06-14  9:13   ` Adam Thompson
2015-06-13 21:39 ` Chris Brannon
2015-06-14  9:11   ` Karl Dahlke
2015-06-14  9:31     ` Adam Thompson
2015-06-14 15:04       ` Karl Dahlke [this message]
2015-06-15 19:59         ` Adam Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514110421.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).