From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-ch2-09v.sys.comcast.net (resqmta-ch2-09v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:41]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 0B4B577ADB for ; Sun, 14 Jun 2015 08:03:00 -0700 (PDT) Received: from resomta-ch2-05v.sys.comcast.net ([69.252.207.101]) by resqmta-ch2-09v.sys.comcast.net with comcast id gF3S1q0062Bo0NV01F4NJc; Sun, 14 Jun 2015 15:04:22 +0000 Received: from eklhad ([IPv6:2601:405:4002:b0a:21e:4fff:fec2:a0f1]) by resomta-ch2-05v.sys.comcast.net with comcast id gF4M1q00T0GArqr01F4NDN; Sun, 14 Jun 2015 15:04:22 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke References: <20150513044849.eklhad@comcast.net> <20150614093106.GB9965@toaster.adamthompson.me.uk> User-Agent: edbrowse/3.5.4.1+ Date: Sun, 14 Jun 2015 11:04:21 -0400 Message-ID: <20150514110421.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1434294262; bh=fP/xgaWzw10IikQhq/u3VaFFheSM/u3f2G9zEeYgLm4=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=aOfE390eWQvMz6hKUCan3ayE8vwNrg4SOWtVhN1zszZ6oMZjUDDRTQaN7OouYS3Yj EHjpSkEt2W+x4tRpX49OItaQ9VMJbrtkIau0az2MYbwJg+kMzHZTC4qWDeMkGYefAP Eduppw/RxiHkVLElsMptVU4m62BVVKLFoyNqMJFrdWacyGWw94SG9LFNFMWZgTlTnl pXTlhNPEPHrq2mM9JfqAO715+U5/iGe/7GkZy2Om8eaNPmQtz1vUYj1aSOUbOyL7Zu v16RAmSudE7n+P3Fq/rqQWJRmgcn9L/wdb446RoitAezG3CgHHXQ0/WzfrMuED4LKI o8/H/YiPzGYIA== Subject: [Edbrowse-dev] getters and setters in straight javascript X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 15:03:01 -0000 It is certainly possible that some of startwindow.js will eventually have to return to native C, appendChild and insertBefore in particular, but only if it must. The advantages of keeping support routines in js are so many and so substantial I don't even have to list them. A 4 to 1 code reduction is just one example. You speak of the day when "we have determined which js engine to use", as though we will know that the js engine will not need to change again. I don't have a lot of confidence that day will ever come. Such things are supported and then not supported. Even if we do settle on one brand, mozilla as an example, the next version might have a completely different api. We've seen that before. All other things being equal, we would want to minimize the code that interacts with the js engine. Call it insurance if you will. As per the URL setters, these had a lot of c++ strings in them, which is why I ran into them in the first place. We were going to have to convert this code back to C strings if it remained native, so I did an easier conversion, that may stand or may not. Yes I agree there isn't much point in moving the document.cookie setter, it's not that much code, it is straight C, it works, and some of it has to be native anyways. The other setters are equally straightforward, and can remain native. So ok, having removed over 1,000 lines from jseng-moz.cpp, and having converted the remaining c++ strings to c, Adam I think we are finally go for launch. Create jseng-duk.c, and I hope it works, and works well, and works cleanly. After a small amount of research, Chris is pretty optimistic. It looks a lot easier to work with than the mozilla beast we've been wrangling with thus far. But only time will tell. Karl Dahlke