Re: [Edbrowse-dev] getters and setters in straight javascript

[Adam Thompson <arthompson1990@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]

On Sat, Jun 13, 2015 at 06:50:49AM -0400, Karl Dahlke wrote:
> This is a followup to my previous message.
> If getters and setters are feasible in straight javascript,
> here is how the url class would look.
> If you paste this into startwindow.js it compiles properly.
> The syntax is right.
> And the code looks right to me, but of course it blows up
> because there are then js setters and C setters and they collide.

Does this actually work with the existing machinary?
Some of the code in startwindow.js doesn't work as expected in terms of
rendering elements (at least as far as I know),
I'm thinking particularly in terms of the link between appendchild and the rendered html.
Of course, if I'm wrong, please correct me.
In addition, we're actually violating the DOM spec by doing some of these
things in pure js since they have the concept of "host objects"
which are defined by the host and don't quite behave like ordinary js objects
in terms of not having prototypes etc.
I guess my thoughts on this are that,
once we actually settle on a suitable js engine (duktape, mozilla,
whatever) we should re-evaluate what's in startwindow.js and what's in c to ensure that:
a) It actually works rather than just keeping js happy
b) it doesn't rely on engine-specific js
c) it's maintainable

Once we sort the parser and js engine,
we'll probably need to combine the two into one process anyway to make this
whole thing work much better since we're going to have to get a better link
between js-generated DOM and html-generated DOM.

Cheers,
Adam.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]