From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-ch2-09v.sys.comcast.net (resqmta-ch2-09v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:41]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 619CB783A6 for ; Sat, 12 Sep 2015 18:19:31 -0700 (PDT) Received: from resomta-ch2-18v.sys.comcast.net ([69.252.207.114]) by resqmta-ch2-09v.sys.comcast.net with comcast id GRMm1r0022Udklx01RNEqT; Sun, 13 Sep 2015 01:22:14 +0000 Received: from eklhad ([IPv6:2601:405:4002:b0a:21e:4fff:fec2:a0f1]) by resomta-ch2-18v.sys.comcast.net with comcast id GRND1r00E0GArqr01RNDld; Sun, 13 Sep 2015 01:22:14 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke User-Agent: edbrowse/3.5.4.2+ Date: Sat, 12 Sep 2015 21:22:13 -0400 Message-ID: <20150812212213.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1442107334; bh=18jWn1Et5FyRqGZ7r985lH+IWsei1G5/rk7MArBc5Ng=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=VA+6Lzzj+f/pqTzvM+Drti4hkFE5bigfTKAlBR64zOVoF/u5DsnuJGSfgrQogSq2g dZJ3LohqLaOY9z+PmaGV6kNIFq+I3fLFbKVb1j1o942YJLhTp9HOsQ3fZiZ/aA9ei5 EYE7QcXFsL14KFWO3H2XQY8rPO92ChojCSEW3ToS+iu/ALgTLtDV1KKs9H1zFO25CG lUTLfFlC1/GaGA5wBXwWECMaX5s4VWDwlbc/+/34gTMymOF1DQqvKmjiJlS2C2P7zT Jlk/PRWU0Ekc3cT3e+p/1074E3uSf+Xvo1LmKZ2un/GSfFF4vKej9iZJt+JtkNqyC+ Y+7dI522kpBvA== Subject: [Edbrowse-dev] tidy script bug workaround X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2015 01:19:31 -0000 Well if they've been talking about this bug since 2007, then they might not fix it soon. With that in mind I was thinking about a preprocessing workaround. My first attempt looked for strings within scripts, and then Received: from resqmta-ch2-07v.sys.comcast.net (resqmta-ch2-07v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:39]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 922C177CC9 for ; Sun, 13 Sep 2015 10:03:02 -0700 (PDT) Received: from resomta-ch2-13v.sys.comcast.net ([69.252.207.109]) by resqmta-ch2-07v.sys.comcast.net with comcast id Gh5n1r0012N9P4d01h5n8c; Sun, 13 Sep 2015 17:05:47 +0000 Received: from eklhad ([IPv6:2601:405:4002:b0a:21e:4fff:fec2:a0f1]) by resomta-ch2-13v.sys.comcast.net with comcast id Gh5l1r00c0GArqr01h5mqh; Sun, 13 Sep 2015 17:05:46 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke References: <20150812212213.eklhad@comcast.net> <20150913163728.GG29720@toaster.adamthompson.me.uk> User-Agent: edbrowse/3.5.4.2+ Date: Sun, 13 Sep 2015 13:05:45 -0400 Message-ID: <20150813130545.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1442163947; bh=wERpH+NEEXL6Oq4wEQQhGfluPGa6jXm4oRVRVetCdkU=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=NsC1HVgZ8Wg5HL4v37Oa4x7k3jPvCFj/XIp++XZDQj+S0gAYVV8EIX3BhJm6+yJR3 c/YZyoV/0zAcBypmCopSePKRM/o+A1UF1rC9563lLmYnchF9SLGoAFBTXYwMYB5K2+ ueTcjnr72UjGFKI9rt9w9mMIAaM0HLDp+I+clElj1A1mY74C2kUG0/u47hZObokgCh 769ttItSu9pPixR5O59c1xoGmTWr80W2JsQ6Rte/4MAC0waIawiOtR1haV7MS6tHXv 0sQQIHNa86xP9qTWE5riSDmUQ01EWj5yK/6Na0hZE7jqdRSrGrQOlMYKgp35sQ117F lkVxXN32dEwWg== Subject: [Edbrowse-dev] tidy script bug workaround X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2015 17:03:02 -0000 > Doesn't this miss the also destructive " does not seem to appear in the wild. In other words, web developers and generators are careful not to crank out the string "......" because anywhere ends the script. My parser has made this assumption for ten years, and it's pretty reliable. They're more than happy to write var a = ""; the latter often written as var a = ""; This too generates a tidy warning, because Received: from mail-wi0-x22d.google.com (mail-wi0-x22d.google.com [IPv6:2a00:1450:400c:c05::22d]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 9ABCC77CC9 for ; Mon, 14 Sep 2015 10:02:30 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so149555747wic.0 for ; Mon, 14 Sep 2015 10:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=B9iHPjPREFSmnIY0LaLw97TtWsPLsQNZ2vBzgaIwpWs=; b=N3G70137IiBwg6kOBC5lWPW3xOxj1z10BECaY5vanfpvcR8jQ9HymGGwi2EPEv2bfF eLRd3o2MmALOFE20ydT40lD3r60Tu29xTTzoXRA2rYnCjQIT2LpPQAR94H0537w2+EL9 sRYRTHO6mYEdMDsmECT1u/UplvgbJL6dLIvccXYIIVw0P+4gH5poJrMpQm7ovHwjWH+4 Cc3WdY4mmj4N69ogbJZF7/T7IdMpf9faSBp9eX3oz7pP5hJ77xmQ1DSQXtdNAh7thGeT ymNx326Gu3ItGULw/nG4gCuagdXTxYzfL+SKyphDkivQuNRjqxBKFhPFizLtCQyiqkOX GtIw== X-Received: by 10.194.248.234 with SMTP id yp10mr77233wjc.24.1442250316482; Mon, 14 Sep 2015 10:05:16 -0700 (PDT) Received: from toaster.adamthompson.me.uk (toaster.adamthompson.me.uk. [2001:8b0:1142:9042::2]) by smtp.gmail.com with ESMTPSA id ex8sm15338565wib.14.2015.09.14.10.05.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Sep 2015 10:05:15 -0700 (PDT) Date: Mon, 14 Sep 2015 18:05:13 +0100 From: Adam Thompson To: Karl Dahlke Cc: Edbrowse-dev@lists.the-brannons.com Message-ID: <20150914170513.GH29720@toaster.adamthompson.me.uk> References: <20150812212213.eklhad@comcast.net> <20150913163728.GG29720@toaster.adamthompson.me.uk> <20150813130545.eklhad@comcast.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9sSKoi6Rw660DLir" Content-Disposition: inline In-Reply-To: <20150813130545.eklhad@comcast.net> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [Edbrowse-dev] tidy script bug workaround X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2015 17:02:31 -0000 --9sSKoi6Rw660DLir Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 13, 2015 at 01:05:45PM -0400, Karl Dahlke wrote: > > Doesn't this miss the also destructive =20 > Yes it does, but "" does not seem to appear in the wild. > In other words, web developers and generators are careful not to crank out > the string "......" because anywhere ends the script. > My parser has made this assumption for ten years, and it's pretty reliabl= e. >=20 > They're more than happy to write > var a =3D ""; > the latter often written as > var a =3D ""; > This too generates a tidy warning, because or but it does not cause trouble and does not derail the script. > So my early research suggests we're ok here. Ok that makes sense. In which case I'm unclear as to why tidy5 wouldn't han= dle