From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-ch2-10v.sys.comcast.net (resqmta-ch2-10v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:42]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 688167891D for ; Wed, 2 Dec 2015 20:51:02 -0800 (PST) Received: from resomta-ch2-10v.sys.comcast.net ([69.252.207.106]) by resqmta-ch2-10v.sys.comcast.net with comcast id ossN1r0012JGN3p01ssWeJ; Thu, 03 Dec 2015 04:52:30 +0000 Received: from eklhad ([IPv6:2601:405:4001:e487:21e:4fff:fec2:a0f1]) by resomta-ch2-10v.sys.comcast.net with comcast id ossV1r00x2MDcd701ssWeV; Thu, 03 Dec 2015 04:52:30 +0000 To: edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke References: <87vb8gra8x.fsf@mushroom.localdomain> User-Agent: edbrowse/3.5.4.2+ Date: Wed, 02 Dec 2015 23:52:29 -0500 Message-ID: <20151102235229.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1449118350; bh=a1tyxiXi8ZTLKv+NTd0ceGae0NXzWF3JYzPAmLUc1mY=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=loVnXjL1a4asL+Qw9CuCSX/Td6y+HNh7YTFsBJdO+f9dpTRD1LM0f9eVPyg8Eu9BC KEtF37ns40QnUMhabAaiMV/or44BS7abgJJ+F5QYQ8ZNjfADqeJ3o8VipOZowBbMFB HoSnZ8gMuUDdhxiR3CV6GHQuaP2iGLECBwphr62FErNp4bLCOAqYLQdixcpzArqVJM 3HiAxQLQvj/UrVrq7q5ztA2ibXh8/3fircZwpgI1QF5IhotqFTEf8kxSqpmB6zChkV bkva1i/91bD5fxarjz7S3JaGuAgJdV4mk2+tppZtUz7w/9Uq2+DnbdSIVtnuP3zPlR 6STBLIbyc/21A== Subject: [Edbrowse-dev] 3.6.0? X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 04:51:02 -0000 Ok, this is good. Kevin I installed your latest patch, tested jsrt etc, and then pushed it to Master, but I don't think removeEventListener is quite right. I'm too tired to look at it now but I'll review it tomorrow. I think you want to compare the passed in function, just as a function, with the functions in the array, and if found use splice to remove it, or if it matches the original function then remove that, or do nothing if it doesn't match any of these. I doubt you want to expand both functions back into source and compare those, but hey I'm not sure. So on we go. Karl Dahlke