edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Adam Thompson <arthompson1990@gmail.com>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] readline input segfault
Date: Sat, 14 Nov 2015 10:52:05 +0000	[thread overview]
Message-ID: <20151114105205.GD2985@toaster.adamthompson.me.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

Hi all,

For a while I've suspected that there's a segfault in the readline input mode of edbrowse.
For various reasons I've now got a little time to debug this,
and it looks like there's an issue between the dynamic allocation used by
readline and the static line length limit used by edbrowse.
The easiest fix would be to read everything in with readline and then only take
the amount that'll fit into the statically allocated array,
but that way we potentially silently (or not so silently) drop user input.
I'm wondering if now would be the time to switch to readline based input
throughout unless there are good reasons (Windows port?) not to do this?

Cheers,
Adam.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

             reply	other threads:[~2015-11-14 10:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14 10:52 Adam Thompson [this message]
2015-11-14 14:42 ` Karl Dahlke
2015-11-14 19:39   ` Adam Thompson
2015-11-14 15:35 ` Karl Dahlke
2015-11-14 19:42   ` Adam Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151114105205.GD2985@toaster.adamthompson.me.uk \
    --to=arthompson1990@gmail.com \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).