From: Karl Dahlke <eklhad@comcast.net>
To: edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] JS interpreter crashes on Google books
Date: Fri, 22 Jan 2016 07:41:31 -0500 [thread overview]
Message-ID: <20160022074131.eklhad@comcast.net> (raw)
In-Reply-To: <20160121124908.GC1722@Kraftkrust>
Well gdb cuts to the heart of it, as it often does.
The problem is in the new xhr system when cw (current window) is null.
And why didn't we see this in our jsrt test?
Because that test runs innerHTML first, which sets cw.
This page has no innerHTML, cw was never set, then xhr blows up.
So I now set cw at the start of js_main().
Not sure the result is much better though.
js script doesn't run perfectly, which reports an error to google via xhr,
and too many errors like this can cause google to block your site, for a while.
google is so complicated, it's not clear edbrowse
will ever truly be able to handle it.
This page does however have {toggle screen reader mode}.
Not sure what that does.
Karl Dahlke
next prev parent reply other threads:[~2016-01-22 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 12:49 Sebastian Humenda
2016-01-22 8:14 ` Karl Dahlke
2016-01-22 12:41 ` Karl Dahlke [this message]
2016-01-22 13:05 ` Sebastian Humenda
2016-01-23 1:41 ` Kevin Carhart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160022074131.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).