From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-ch2-03v.sys.comcast.net (resqmta-ch2-03v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:35]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 9D48477C9F for ; Sun, 7 Feb 2016 03:04:39 -0800 (PST) Received: from resomta-ch2-07v.sys.comcast.net ([69.252.207.103]) by resqmta-ch2-03v.sys.comcast.net with comcast id FP531s0022EPM3101P53HF; Sun, 07 Feb 2016 11:05:03 +0000 Received: from eklhad ([IPv6:2601:405:4001:e487:21e:4fff:fec2:a0f1]) by resomta-ch2-07v.sys.comcast.net with comcast id FP521s0082MDcd701P52VK; Sun, 07 Feb 2016 11:05:03 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke References: <20160207100300.GA8740@122oven.adamthompson.me.uk> User-Agent: edbrowse/3.6.1+ Date: Sun, 07 Feb 2016 06:05:02 -0500 Message-ID: <20160107060502.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1454843103; bh=G1cV9//hOu+hTeOk2Vk4b9+bMCabcVq1EVD7yT16y8Q=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=CksHj5bggB4T1ptKP2MwuJPSK7ek6kptt98TEcC1sK+iIUFNZgVoKd1h/047mw5Uy fwI+IdL4AaMbVRcMId2zeIdpeBAmlZxi8tCd4cEqegXCX4hiTSTColDqHI6IHoNwWp dRAJf/W0ZUd80qihwmc97Vk0I0Jz7fTnhagSztzBN+YAqIoDaLNEFmNDCWWWCLcsuD 1icK9UPl90huX15iqeU+AgNFbBmVFX7+PlAKZlJpnvMWPJ8khmb9iK0OgKE2d8yoiE RzCmossS0jPBqg/5fFZJIozQre3qh+8WkPQTKpmFzqsQYKjmk3RtCImLa4dMqd9w+w rQiT5uKiDePtw== Subject: [Edbrowse-dev] Odd google download behavior X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Feb 2016 11:04:39 -0000 > download prompts when using google services Yup, even to sign into google it asks you to download twice. Our code has not changed to cause this behavior, rather, google has changed its http headers in a way that is entirely reasonable but happens to reveal a longstanding bug in edbrowse. I ran with db4 and db>/tmp/google, and boy do I like the db> feature!! Some of the 302 redirections set content-type: application/binary. Well there isn't any content so you can call it anything you like I guess, but that triggered the state to ask the user if maybe he wants to do a download, but that is trumped by the 302 and on we go. Then I didn't reset the state back to 0 for the next fetch, which is a normal web page but still asking about download cause of the page before. The fix is basically one line, set state = 0 at the top of the refetch loop, and it is pushed. Karl Dahlke