From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-ch2-08v.sys.comcast.net (resqmta-ch2-08v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:40]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 1C7B47913E for ; Tue, 24 Jan 2017 12:48:10 -0800 (PST) Received: from resomta-ch2-04v.sys.comcast.net ([69.252.207.100]) by resqmta-ch2-08v.sys.comcast.net with SMTP id W80QcDvBJdT7bW81LcvzMo; Tue, 24 Jan 2017 20:48:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20161114; t=1485290931; bh=QU1JgDSnbkP+r/O87iNJzxwPBSdfGVXeRKmD4Tleq18=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=A8vSUwSNMh3mulLpdcZnwUG6iUD0anhDTaY/mFSd/wdEf2piYJ5EZCRqf6Yjd8Py5 CEt8Kv1QbpgP3izHUoAyz7RvNwe6T2g/TKdQ1fFdmL/+ILRmuSETgEzQhPbcIh1tQ+ 2XvBzoJ60GCMX1MhUhQfp5JabMzbg67epZ4vMSMgi7VKwZdSNSmYhzDxZPPyX33N2m 4Ir7ibskCj/+ZeEbOEf3ZKQ0elx7sxeo9EjdPIgITRzrK8hfcAVvDUK3hHeYAW1k7m Wjdnm1qhwKfp4+qb0ksaWCXio5k8W3O/6jkJZaAKVQSI+6t6CKMSaNNtsSUE6R6tta o8Ej9X2DxOmKg== Received: from unknown ([IPv6:2601:408:c301:784d:21e:4fff:fec2:a0f1]) by resomta-ch2-04v.sys.comcast.net with SMTP id W81JcVzaEDXgCW81Kch0lK; Tue, 24 Jan 2017 20:48:50 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke References: <20170119200417.GA5912@odin> <20170124190824.GA6334@odin> User-Agent: edbrowse/3.6.2+ Date: Tue, 24 Jan 2017 15:48:49 -0500 Message-ID: <20170024154849.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfF2058b5/lNIPaCh2WCRUZusArw1PG6U7H6I352nFR2xIPcDO1tBXx+lxPAGho1oVlifCRhWtPdTem9XsqeJ6blexVAXuoOZXQ9aglIyEPCXGVDIhMzN yxmI1Cs5tWwF443gvYQlpKdHNmcCP9NiveopmJ5MbhDjiVwNxz/UeIaz Subject: [Edbrowse-dev] document.removeAttribute X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.23 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 20:48:10 -0000 I'm a bit confused. It all works if you remove an attribute that is there, but if you remove an attribute that isn't there ... startwindow.js line 233 c.attributes = new Object; Not an array but an object. So if c doesn't have foo then you try to get attributes.length like it's an array but it's not, so I think that would fail and stop js right there. Same problem for hasAttribute etc. Look at decorate.c line 825. There I make attributes an array. I think maybe startwindow.js should read c.attributes = new Array; That would be consistent. If so then it's my bug, sorry. What say you. Karl Dahlke