From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-ch2-07v.sys.comcast.net (resqmta-ch2-07v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:39]) by hurricane.the-brannons.com (Postfix) with ESMTPS id B56DB7A514 for ; Sun, 9 Jul 2017 08:44:43 -0700 (PDT) Received: from resomta-ch2-09v.sys.comcast.net ([69.252.207.105]) by resqmta-ch2-07v.sys.comcast.net with ESMTP id UEOUdICIqWKMWUEOidE2M2; Sun, 09 Jul 2017 15:45:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20161114; t=1499615124; bh=1ckPgGLrKF1BFiTyo5ORgUbmoO5ibWkuC7bvTR9AJRQ=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=NV1UpYpp7ULlhXHv1pjVzKHo7alTy3mXZJW79gwWt2FP9wVmdxr3t9j7NfU3V4NpM tiZ6ZVarPYCcdC9lttM3U5OCk+aPnirW3q6Zp6wRPLIKsyI1IYVWxcDi4PNWo/xfmI Mx4oqOPP7+yUq/tokq00WropUgUOg05kk1G3ajzlhDko0hfKqnIlVyE6GK7oxagG4r DbCAAFLb5BgkLMoeEqvyrmH7vHTonLC9D9UWjIU3kz2S30vwOHogIMcyh6AnA6s54S u9Ow433TwcUHmvrDQkrAooIlKQfzm0ycPloXqIA1Bo4jxU0o3XV2rEwhAFmf+QGK+E p1Xref63F8X1A== Received: from unknown ([IPv6:2601:408:c301:784d:21e:4fff:fec2:a0f1]) by resomta-ch2-09v.sys.comcast.net with SMTP id UEOhdLltgh8eeUEOhd5IKe; Sun, 09 Jul 2017 15:45:24 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke References: <20170703051927.GA1994@nautica> <20170709144030.GA24038@nautica> User-Agent: edbrowse/3.6.3+ Date: Sun, 09 Jul 2017 11:45:23 -0400 Message-ID: <20170609114523.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfDA1OC5S8g0jyPRihyodILmECPrdJKJRPoL1dXFEWQZCCXEugZXT/eQ//Lj9xPM7/nENzT++mobo0QO+lhBP89I6aKxbpSUpMDDB5YG/SOwk1SrHEjNe fpKN2cKt+IqX/HDjtVECeo4k0prCFFyprRxRloAzJQSLOlyacKz13qxb Subject: [Edbrowse-dev] Disabling local echo for password fields X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 15:44:43 -0000 I will have to defer to Chris for most of this. I am off in another branch, the duktape branch. Literally up to my elbows in the conversion work. If Chris thinks the patches look ok he can integrate them into master branch. You're right, mucking with removeHiddenNumbers() is probably the right way to do it, and I can't think of any problems here, but I'd have to check all the places it is called and see if there are any issues with stars instead of text, I don't think there are. And it has the advantage that you can write the buffer to a file etc and it still has the stars. Good call. Yes I forgot Password was a major type, honestly it probably shouldn't be. It's a minor variation on the text type, but it is what it is, so carry on. Karl Dahlke