From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nautica.notk.org (nautica.notk.org [91.121.71.147]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 2B85D7A4D9 for ; Sun, 9 Jul 2017 21:56:09 -0700 (PDT) Received: by nautica.notk.org (Postfix, from userid 1001) id 64F58C01C; Mon, 10 Jul 2017 06:56:51 +0200 (CEST) Date: Mon, 10 Jul 2017 06:56:36 +0200 From: Dominique Martinet To: Edbrowse-dev@lists.the-brannons.com Message-ID: <20170710045636.GA3943@nautica> References: <20170703051927.GA1994@nautica> <20170709144030.GA24038@nautica> <20170609174513.eklhad@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170609174513.eklhad@comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [Edbrowse-dev] Disabling local echo for password fields X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 04:56:09 -0000 Karl Dahlke wrote on Sun, Jul 09, 2017: > I got the patch out of github, it will take a while to look through, > not a lot of code but a lot of little changes all over the place. Thank you; I was not sure on where to add code first so the code itself was done quickly/is not polished. If the place/global logic fits then it is a good start for me, I should have been more explicit about that. > if (!cw->browseMode && (cmd == 'i' || cx)) { > # why query cmd and cx, neither has been set to anything at this point. > # cmd is the default p for print, I think. Eep, you've caught some shameful copy/paste error here as I copied that from the 'i' command block. I had meant to only test browseMode (same for range) > setError(MSG_NoBrowse); > return false; > } > if (endRange > startRange && cmd == 'i') { > # again, cmd will not be set to i. > # Did you test all these cases? 1,3ipass will probably not fall into this > # block the way you want it to. You should test every pathway. > setError(MSG_RangeI, c); > # c has not been set. > # setError(MSG_RangeI, '='); MSG_RangeI is 'i' specific, we're going to need a new message (or make the msg take a string as argument like fieldInputField) > # is cx set to 0 at this point? I think so. yes > tagList[tagno]->itype = INP_PW; > # Hold it! I have a real problem overriding the html tag type. > # Mostly on philosophical grounds. I think others will as well. > # Chris says it is always password when it's suppose to be a password, > # almost always, so don't think we should change it. > # In an extreme case it could have been a select list, menu of choices, > # and now it's just a password text field and I'm sure that will > # make something blow up somewhere. Right, I hadn't thought of radio and other type of fields as there weren't any on the page I tested. I agree something will likely break in that case, but I would like to disable echo for informations entered with that even if the field is not set -- I think in that case it makes more sense to revert INP_PW as a minor type, I will implement that as you suggested in your earlier mail. -- Dominique