From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nautica.notk.org (nautica.notk.org [91.121.71.147]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 9175C7A06A for ; Tue, 11 Jul 2017 23:10:44 -0700 (PDT) Received: by nautica.notk.org (Postfix, from userid 1001) id A90ACC01B; Wed, 12 Jul 2017 08:11:30 +0200 (CEST) Date: Wed, 12 Jul 2017 08:11:15 +0200 From: Dominique Martinet To: Chris Brannon Cc: Edbrowse-dev@lists.the-brannons.com Message-ID: <20170712061115.GA3270@nautica> References: <20170703051927.GA1994@nautica> <20170709144030.GA24038@nautica> <20170609174513.eklhad@comcast.net> <20170710045636.GA3943@nautica> <87tw2joaop.fsf@the-brannons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87tw2joaop.fsf@the-brannons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [Edbrowse-dev] Disabling local echo for password fields X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 06:10:44 -0000 Chris Brannon wrote on Mon, Jul 10, 2017: > The inp_types list in decorate.c is also duplicated in html.c, and you > missed that one in the patch to add the new minor type. > Couldn't we just get rid of the inp_types from html.c and make inp_types > from decorate.c global? I have done just that: removed inp_types in html.c and declared as extern in eb.h I think 'number' might also need to be moved to minor, but did not take the time to change that. > I'd also say that the function infShow needs to be reworked a little, so > that it shows the minor type, and not just text. > I'd like Karl's opinion on that. If he agrees, I wouldn't mind doing > that work after your patches are submitted. That would make sense to me, I have made both inp_types and inp_others global at the same time so you will be able to use it. > Aside from all of that, your patchset looks pretty good. > I still want Adam's opinion on the auth negotiation. I don't know if > his issue still exists, or whether it was subsequently fixed by libcurl > / other software. I have repushed the series without the last curl auth negotiation patch, so we are not held by that. The patch is still available in my master branch on github ( https://github.com/martinetd/edbrowse ) I have also added a first draft to the userguide, both in English and French, for the new command. We cannot change the command name once this is merged so now is a good time to complain about my naming sense! -- Dominique