From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:558:fe21:29:69:252:207:42; helo=resqmta-ch2-10v.sys.comcast.net; envelope-from=eklhad@comcast.net; receiver= Received: from resqmta-ch2-10v.sys.comcast.net (resqmta-ch2-10v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:42]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 0F56C77DE8 for ; Sun, 13 Aug 2017 23:35:49 -0700 (PDT) Received: from resomta-ch2-09v.sys.comcast.net ([69.252.207.105]) by resqmta-ch2-10v.sys.comcast.net with ESMTP id h8yfdfcrRMWjBh8yfd8bFr; Mon, 14 Aug 2017 06:35:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20161114; t=1502692553; bh=fzWlw4hj5d4ZjFq3b8Q4CPU5IOd1OqHeia+J7rdpW4Q=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=GtLnKznn6pRTahAeWLorihA4VxKxWc6uSXjHH0OJo7VSpxfQyjrZyIHBtfnRA7QV2 LReCmJ+k8ITrgzA315gq0H7sFreX4YGAFFbHGnBZNdT5/YkgPPrdAdQz9dWT7icAZa wpIK2CfKo/utZtu8a+Rz+IT2aRLDsoGQQyHd/ScqmzJH063DAoLPpb3Ngtsfl7GV+r ArOH4jrtupWZMPEdkvim8Qifu4cXfzamhdqCbxgq/fkFK62CYLpVrfAh80twatX/5v dRNQWRnQrMHTtmwBSehQp8w8Lsv6M9KOHw6JeOsnDhVt8daUZS0+oqTqUFq4hddo4F BAtmCE4GXXVFg== Received: from unknown ([IPv6:2601:408:c301:784d:21e:4fff:fec2:a0f1]) by resomta-ch2-09v.sys.comcast.net with SMTP id h8yedIMK15oEJh8yedxxqK; Mon, 14 Aug 2017 06:35:53 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke References: <20170713214236.kevin@carhart.net > User-Agent: edbrowse/3.7.0+ Date: Mon, 14 Aug 2017 02:35:52 -0400 Message-ID: <20170714023552.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfN7h9oJrZiBakrMZQNSNvHRrMV57MzWzrd1edQhQCg81b53Clv44z7dp9hEM3cMF45Uf3U9ldAbetKHVkPUSW3ebiP5nAmPU6hHkXAG+e7roNDFeMbZy 1CboSWaTHfxUUROW23iKYIfMuRCaNe8dPyo3oAPDu7t8wnDH6P6z9btP Subject: [Edbrowse-dev] defaultView and getComputedStyle patch X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Aug 2017 06:35:50 -0000 I went ahead and pushed this patch because it does no harm and moves you forward, but it still confuses me. Your getComputedStyle function at line 759 is equivalent to function getComputedStyle(e, p) { return e.style; } The obj variable is local and goes away when the function returns. So why not write it my way it's a whole lot easier to understand. Unless I'm missing something. Karl Dahlke