From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nautica.notk.org (nautica.notk.org [91.121.71.147]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 867C27A06A for ; Sat, 15 Jul 2017 04:29:14 -0700 (PDT) Received: by nautica.notk.org (Postfix, from userid 1001) id DC5FCC009; Sat, 15 Jul 2017 13:30:06 +0200 (CEST) Date: Sat, 15 Jul 2017 13:29:51 +0200 From: Dominique Martinet To: Edbrowse-dev@lists.the-brannons.com Message-ID: <20170715112951.GA16585@nautica> References: <20170703051927.GA1994@nautica> <20170712061115.GA3270@nautica> <20170612084400.eklhad@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170612084400.eklhad@comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [Edbrowse-dev] Disabling local echo for password fields X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jul 2017 11:29:14 -0000 Karl Dahlke wrote on Wed, Jul 12, 2017: > The mask bit would get around this. > > bool masked:1; I have done that, you can find a new version in the pull request: https://github.com/CMB/edbrowse/pull/29 > if(t->masked || t->inp_minor == INP_PW) { put in stars } I preferred setting the masked flag when we set minor INP_PW instead Since the masking/ipass commands no longer use the itype_minor field, I have pushed it off separately, you can find it here: https://github.com/martinetd/edbrowse/tree/itype_minor This includes moving 'number' onto inp_others and displays it in parenthesis in infShow, so a number would look like this with i? "text (number) num_field_id" (I have also left the curl auth patch in my master branch, on top of it again) I am still not convinced about github pull request system, but once this gets in I will submit another PR for itype_minor if that is fine with you (and eventually a third for the curl auth patch, if we can hear back from Adam) -- Dominique