edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] other bugs
Date: Thu, 24 Aug 2017 06:15:00 -0400	[thread overview]
Message-ID: <20170724061500.eklhad@comcast.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

The problem with using third party software is we sometimes find their  bugs, and then hope they fix them, or we work around them.
acid test hunts for corner cases so not surprising it uncovers bugs.
I already wrote about the tidy bug, not giving us the empty nodes, which test 0 expects to be there, and so I guess every other browser puts them there.
I sent this question to Geoff.
But turning to css, there are more problems.
The parser that Kevin found for me doesn't parse comments corectly.
If a comment contains a selector it is treated as a selector, not a comment, and it's all screwed up from there.
I reported this to jotform, no response yet.
Ok this one seems like an easy work around.
I don't need the comments preserved for any reason, so just strip them out with a preprocessing regexp.

css_string = css_string.replace(/\/\*(.|\s)*?\*\//g, '');

Yeah I know, it looks like line noise in the modem, but it's right, I'm pretty sure, and works on the modest test strings that I give it,
but it doesn't work on the style block that is part of acid test 0.
RangeError: regexp executor recursion limit
I used the nongreedy modifier to the wild card, so there really shouldn't be any recursion at all, so I don't get it.
I sent this to one of the duktape developers.

With all these issues hanging, I'm rather in a holding pattern as per the acid tests.

Karl Dahlke

             reply	other threads:[~2017-08-24 10:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 10:15 Karl Dahlke [this message]
2017-08-25  3:58 ` Kevin Carhart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724061500.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).