edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] xqsuperschool.org (fwd)
Date: Fri, 08 Sep 2017 18:23:19 -0400	[thread overview]
Message-ID: <20170808182319.eklhad@comcast.net> (raw)
In-Reply-To: <alpine.LRH.2.03.1709081439580.12574@carhart.net>

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

> Come to think of it, if the users did have this, they might
> be able to report an error message back to us with a line number in it.

That is true iff the feature runs all the time, and not based on some toggle flag.
It's hard to imagine that impacting performance significantly.
It's just one more step in js compilation.
But ...

1. If the code is clean, not minimized, pushing it through this machine could make it worse, not better.
In fact we might skip this step for any js with more than 20 lines, as that is probably not minimized.
So if jmin is set and line count < 20 then deminimize it.

2. We would have to know this machine works for *every* js out there.
A utf8 char or a really weird regular expression won't derail it.
So it's another possible point of failure.

So I might like to keep this feature for us, based on a flag or something, and then the normal user
wouldn't give us a meaningful line number, but we probably have to reproduce his bug in our world anyways, so we just turn the flag on.

Karl Dahlke

  reply	other threads:[~2017-09-08 22:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08 21:12 Kevin Carhart
2017-09-08 21:35 ` Karl Dahlke
2017-09-08 21:57   ` Kevin Carhart
2017-09-08 22:23     ` Karl Dahlke [this message]
2017-09-08 22:36       ` Kevin Carhart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170808182319.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).