From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:558:fe21:29:69:252:207:38; helo=resqmta-ch2-06v.sys.comcast.net; envelope-from=eklhad@comcast.net; receiver= Received: from resqmta-ch2-06v.sys.comcast.net (resqmta-ch2-06v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:38]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 056E6779AA for ; Wed, 22 Nov 2017 07:47:30 -0800 (PST) Received: from resomta-ch2-07v.sys.comcast.net ([69.252.207.103]) by resqmta-ch2-06v.sys.comcast.net with ESMTP id HXGQeGqcUML7THXGieQK3B; Wed, 22 Nov 2017 15:48:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20161114; t=1511365736; bh=BTYPJitKXkVFIqteIpV25O39gdDes6Y7/PHCDATdFjo=; h=Received:Received:To:From:Reply-to:Subject:Date:Message-ID: Mime-Version:Content-Type; b=dE/zN/LV9o9c/zdErYCUA22bxg+wo44gtPCNVescQQCyV1B8NJIbHxCahVDGEd3tC xUyEX2wk5hHrXowZXmGl3ow8Z6o67lei+NlHM3rivJ8YmKZgSXVjfgZb5rcajRaeiB BPb2t8zC/2jCE3ZRlX60/lWGVhjfkr9qkT6DfkKhswq6k5bqeMr4Eoyv8YqlYzV9jC dHjr6IHnVbI8jKaHeu6uel4c4vb2uhAT7T/+CliLwWRDm7QBzChPEQJsddm7QGdvca /Dhv+dJU3tMZJq/EJiWNH09/MTvde0Z23odrLs3yKLPzCEElV6JeRL7C77IHx2iuKn /bdA1XNnbk25w== Received: from unknown ([IPv6:2601:408:c300:8f09::3e2d]) by resomta-ch2-07v.sys.comcast.net with SMTP id HXGhern1ILTOcHXGieO9DU; Wed, 22 Nov 2017 15:48:56 +0000 To: Edbrowse-dev@lists.the-brannons.com From: Karl Dahlke Reply-to: Karl Dahlke References: <20171016072958.eklhad@comcast.net> User-Agent: edbrowse/3.7.1 Date: Wed, 22 Nov 2017 10:48:55 -0500 Message-ID: <20171022104855.eklhad@comcast.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfL7l9MggNCjiRh2sLjFAqL+c+tZd/giY6yA16fiOdS6mYyaoANThT5KTAYBQ1kpEUhVVfaquucayaOahkvDr1VZvtzOb9KuQumYL4sehb70AVHh9oJfg nW4kh/nl7aVQWVIM+HcZu97g09rQaZULmFRNha5F6SnsOBIY33Dj4EVD Subject: [Edbrowse-dev] data-* attributes X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 15:47:31 -0000 > Karl, you asked about the site oranges.com and said links aren't working > There is something going on with the attribute data-source, Yes, you're right, this is a problem that we must fix. I'll write more on that later. Oddly enough, that's not why the link doesn't work. I can set the attribute as it should be via jdb, and still the link doesn't work. The onclick function returns nothing, and it should return true or false. I interpret nothing as false, and the hyperlink does not run. This is a real world website, so I guess I should interpret undefined as true, and move forward with the link. Similar comments apply for submitting a form etc. My last push makes this minor yet important change. It's possible that a lot of links on a lot of websites will start working. Here are the comments that I added to the source. /********************************************************************* run_function_bool() This function is typically used for handlers: onclick, onchange, onsubmit, onload, etc. The return value is sometimes significant. If a hyperlink has an onclick function, and said function returns false, the hyperlink is not followed. If onsubmit returns false the form does not submit. And yet this opens a can of worms. Here is my default behavior for corner cases. I generally want the browser to continue, unless the function explicitly says false, or fails. the function doesn't exist. (false) The function encounters an error during execution. (false) The function returns a bogus type like object, or a string like foo that is not true or false. (true) The function returns undefined. (true) *********************************************************************/ Karl Dahlke