edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] nasa / prepending "on" to events
Date: Fri, 26 Jan 2018 01:43:13 -0500	[thread overview]
Message-ID: <20180026014313.eklhad@comcast.net> (raw)
In-Reply-To: <alpine.LRH.2.03.1801252110350.27769@carhart.net>

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

Ok, I made this change, but it raises yet more questions.
An onclick tag in html creates a function called onclick(), executable via foo.onclick().
It does not get stripped to click().
And when we click on that button, we are running onclick(), not click().
I'm pretty sure that's right.
So how does that mesh with click()?
When you click on a button or link, are we suppose to try to run both click() and onclick()?
If not, then when on earth do the click() handlers run?

Same question for unload().
I run onunload() when a page is finished, should I also be running unload()?
I'm confused.

Another interesting snippet from your code is

r !== r.top

That is a test to see if we're a frame inside the window, not the top window.
It means the stuff after is only suppose to happen in frames.
You can see top being set in http.c line 2643.
I mention this because it first looks mysterious, but I'm pretty sure that's what it's doing, and I'm pretty sure edbrowse does it right.

A time (to illustrate) when we want == and not === is startwindow.js line 1156.

Karl Dahlke

  reply	other threads:[~2018-01-26  6:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19 20:08 [Edbrowse-dev] Error Object Karl Dahlke
2018-01-19 20:51 ` Dominique Martinet
2018-01-25 10:48 ` [Edbrowse-dev] defaultView / cloning onevent$$array Kevin Carhart
2018-01-25 14:07   ` Karl Dahlke
2018-01-25 23:07     ` Kevin Carhart
2018-01-26  2:58       ` Karl Dahlke
2018-01-26  3:50         ` [Edbrowse-dev] nasa / prepending "on" to events Kevin Carhart
2018-01-26  4:59           ` Karl Dahlke
2018-01-26  5:51             ` Kevin Carhart
2018-01-26  6:43               ` Karl Dahlke [this message]
2018-01-26  8:10                 ` Kevin Carhart
2018-01-26  8:21                   ` Kevin Carhart
2018-01-26  9:08                     ` Karl Dahlke
2018-01-26 10:38                       ` Kevin Carhart
2018-01-26 14:32                         ` Karl Dahlke
2018-01-26 19:13                           ` Geoff McLane
2018-01-26 19:28                             ` Karl Dahlke
2018-01-27  3:52                           ` Kevin Carhart
2018-01-27 18:52                             ` Geoff McLane
2018-01-27 21:10                               ` Karl Dahlke
2018-01-28  3:12                               ` Karl Dahlke
2018-01-28 19:19                                 ` Geoff McLane
2018-01-28 21:35                                   ` Karl Dahlke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180026014313.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).