edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] stackoverflow and css
Date: Sun, 11 Feb 2018 13:53:51 -0500	[thread overview]
Message-ID: <20180111135351.eklhad@comcast.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

The css portion, that maps css attributes over to objects, takes 2 minutes to run.
That's not the infinite loop, but it is intolerable nonetheless.
Browse www.stackoverflow.com with db3 and watch 2 minutes go by between

execute eb$qs$start
execution complete

The version we got was built to run and handle all situations, and be robust, but obviously not optimized.
Optimizing things is something I'm good at, but it's a lot of code doing something I'm not entirely familiar with, so I would be taking a big bite.
Could it be optimized and still be javascript? Is it primarily an algorithmic inefficiency?
Or would it have to be rewritten in C?
I hope the former, because turning all that into C would be a pain!
There's no real reason to mess with the css parser, that runs once and pretty fast,
but querySelectorAll compares every css directive against every node in the document, which is potentially an n^2 problem.

Karl Dahlke

             reply	other threads:[~2018-02-11 18:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11 18:53 Karl Dahlke [this message]
2018-02-11 19:25 ` Adam Thompson
2018-02-11 19:43   ` Adam Thompson
2018-02-11 21:03     ` Karl Dahlke
2018-02-11 21:24     ` Karl Dahlke
2018-02-13 19:05       ` Adam Thompson
2018-02-11 23:08     ` Karl Dahlke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180111135351.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).