From: Adam Thompson <arthompson1990@gmail.com>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] protocol handlers and outputting to buffer
Date: Fri, 26 Jan 2018 18:01:06 +0000 [thread overview]
Message-ID: <20180126180106.t5yhqm3c7pjpjqvm@toaster> (raw)
Hi,
Whilst messing around with protocol handlers in edbrowse (specifically to make a gopher plugin), I found that the protocol based plugin support has no support for outputting to the buffer as in the converter plugin support.
Specifically, whereas running a converter plugin allows a pipe, the protocol handlers in http.c always call the command using eb_system().
Is there any reason for this or would it be possible to use the command running code from runPluginConverter (may be by pulling out into a generic function so the return codes work) in the protocol handler running code in http.c?
This'd allow other protocols to be added as plugins whilst still keeping the edbrowse interface for cases where one wants to download (and possibly preprocess) using an unsupported protocol
but display and interact using the edbrowse buffers.
If there's no objections to the change I can make the change as I've some time this weekend.
Cheers,
Adam.
next reply other threads:[~2018-01-26 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 18:01 Adam Thompson [this message]
2018-01-26 18:13 ` Karl Dahlke
2018-01-27 9:58 ` Adam Thompson
2018-01-27 14:40 ` Karl Dahlke
2018-02-01 19:58 ` Adam Thompson
2018-02-01 20:28 ` Karl Dahlke
2018-02-09 18:44 ` Adam Thompson
2018-02-09 20:10 ` Karl Dahlke
2018-02-11 16:41 ` Adam Thompson
2018-02-11 16:54 ` Karl Dahlke
2018-02-11 17:14 ` Adam Thompson
2018-02-11 17:40 ` Karl Dahlke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126180106.t5yhqm3c7pjpjqvm@toaster \
--to=arthompson1990@gmail.com \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).