edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Adam Thompson <arthompson1990@gmail.com>
To: Karl Dahlke <eklhad@comcast.net>
Cc: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] version
Date: Thu, 15 Feb 2018 18:48:50 +0000	[thread overview]
Message-ID: <20180215184850.ovv4g5gh2pm64ooe@toaster> (raw)
In-Reply-To: <20180115065635.eklhad@comcast.net>

On Thu, Feb 15, 2018 at 06:56:35AM -0500, Karl Dahlke wrote:
> To recap, I created a nightmare with css parsing and querySelectorAll, because we had to, because some websites need it,
> then I fixed the nightmare, so it doesn't bog down every site you look at.
> With this in mind, and the other changes in the past few months, I think we should stabilize, then stamp a new version.
> Fix bugs or make small enhancements (these are often the same thing), sure,
> but no more major redesigns until 3.7.2.

Yeah sounds like a good idea.  To that end there're a couple of small fixes which we need:
- a form with an action of "" (or empty) is, as I recall, supposed to use the current url as its destination
(at least that's the behaviour I remember and on https://www.eaglemusicshop.com/ with the add to basket buttons)
- On that site there's also a button used as a link running the onclick code to send the browser to a new page.
That currently fails with the quite correct message that the button isn't part of a form.  I think we're
supposed to run the onclick code (or any click events) in any case.

> Adam I still think we could put your gopher changes in, if you're up for that, I don't view that as a major redesign.
> That would be a good thing to have.
> But if you think that might not happen for a couple months then maybe move it to the next version.

I think we set a time (subject to a bit of change) and if I've got something working then it goes in,
otherwise not.  We really need the current changes so they get priority.  If I miss with the gopher
stuff then that's a shame but not much more.

I've also removed a few unused things today as tidy-up.  I'm currently wondering where the mail server socket from
the mail sending mechanism is used as I can only find (with grep) a reference to it being defined and declared
as an extern but no actual usage.
I'm guessing it's actually used and don't use that part of the code so I'm not touching it.

Other than that, I'm not sure what else we need to sort, there may be a few more major changes we want,
but as previously stated, I think we need the css and query selector stuff quite urgently.


  reply	other threads:[~2018-02-15 18:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 11:56 Karl Dahlke
2018-02-15 18:48 ` Adam Thompson [this message]
2018-02-15 21:04   ` Karl Dahlke
2018-02-16 19:11     ` Adam Thompson
2018-02-18  2:19   ` Karl Dahlke
2018-02-18  2:42     ` Kevin Carhart
2018-02-18  3:03       ` Karl Dahlke
2018-02-18  3:39         ` Kevin Carhart
2018-02-18  7:43           ` Karl Dahlke
2018-02-18  8:17             ` Dominique Martinet
2018-02-18  8:47               ` Dominique Martinet
2018-02-18  8:30             ` Kevin Carhart
2018-02-18  7:45         ` Kevin Carhart
2018-02-18  8:55           ` Karl Dahlke
2018-02-18 11:29           ` Karl Dahlke
2018-02-18 14:08           ` Karl Dahlke
2018-02-19  1:07             ` [Edbrowse-dev] version / dyndns Kevin Carhart
2018-02-19  3:58               ` [Edbrowse-dev] update on dyndns Kevin Carhart
2018-03-24 16:07 [Edbrowse-dev] version Karl Dahlke
2018-03-25  8:11 ` Kevin Carhart
2018-06-11 15:45 [edbrowse-dev] version Karl Dahlke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215184850.ovv4g5gh2pm64ooe@toaster \
    --to=arthompson1990@gmail.com \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    --cc=eklhad@comcast.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).