Re: [Edbrowse-dev] :before :after

[Adam Thompson <arthompson1990@gmail.com>]

On Tue, Feb 20, 2018 at 06:56:52AM -0500, Karl Dahlke wrote:
> css can inject text into your document. I had no idea!
> It's not just colors and fonts and decorations, it can inject words.
> https://www.w3.org/TR/CSS21/generate.html

Wow, yeah... I never even imagined it'd do something like that.

> The first thing you'll notice is that :before is on the wrong side of the descriptor. It is a bad design that is cast in stone.
> :before is a selector but it is always true, it doesn't select anything.
> It is an action, and should be on the right.
> So we have to move it, functionally, if not physically, to the right.
> If present, *none* of the directives apply to the current node, except for content.
> Content:blah puts blah before, or after, everything under the current node.
> 
> p.note:before { content: "Note: " }
> 
> I need to create a text node, or a span, probably a text node, with contents blah,
> and then use either insertBefore or appendChild to paste it in.
> From there it will be rendered and you'll see it as usual.
> Not too hard, but there is fallout.

Should it actually appear in the DOM as a node or is it just for display i.e. should js see this node, or does it matter if it can?
Also, what happens if someone shoves html in there (if that's even possible).  Should it be rendered and parsed into the DOM?

> Here's the really bad news.
> I don't do any of this stuff, because I didn't think I had to.
> And that shaves almost 2 minutes off the browse time for stackoverflow, with its 5,000 selectors.
> I apply selectors to each node on demand, if and when you access the style element, and I thought that was really clever, and I guess it is,
> because I don't spend 2 minutes on stuff that doesn't matter, yet I still do what needs to be done on demand, but,
> I'm not injecting snippets of text before or after elements,
> and that changes the way the document might read.

Yeah, it's annoying we lose this.  I've not looked through the CSS parsing logic but is it possible to only apply *these* selectors and quickly skim over the rest and do the on-demand stuff for them?

> All this may have to wait until after 3.7.2, because right now I'm not even sure how to procede.
> BTW, I still hope we can cut 3.7.2 on Sunday, assuming we quit finding bugs, or at least problematic bugs.

Sounds like a plan.

Cheers,
Adam.