[edbrowse-dev] window.location.search and String.search

[Karl Dahlke <eklhad@comcast.net>]

Ok this is fun, isn't it?

It took me a while even to replicate your situation.

The js you refer to comes from a domain doubleclick.net, which I supressed long ago.
It's adds, so I don't care about it.

nojs = doubleclick.net

I commented out the whole nojs block so I could run all the javascript.
I still didn't get your file, at all.
I realized I routinely spoof the internet by pretending I am internet explorere.
	(If I don't do this there are no h3 headins on google search)
The website doesn't even go down this path for IE.
So I set ua0 so I'm back to edbrowse.
Now, finally, I fetch the same scripts as you and see the same error.

snapshot()

Now I can replicated here on my machine and put in breakpoints etc.
eval($bp) as you suggest.
Yes I'm calling search on a url object. Oops.
It's not window location as you thought.

a === window.location
false

Not document.location either.
It's document.URL.
A little more internet research, and document.URL is suppose to be a string, not a URL, its name notwithstanding.
So I was right to think we were barking up the wrong tree, don't mess with overlaid search functions,
what is passed in shouldn't be a URL at all.
It's a one line fix in ebjs.c line 795.
Now the error goes away.
But no worries, I'm sure you'll find plenty more.

Karl Dahlke