From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by hurricane.the-brannons.com (Postfix) with ESMTPS id CBA7478835 for ; Sun, 8 Dec 2019 05:22:51 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id c14so12987692wrn.7 for ; Sun, 08 Dec 2019 05:22:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FMww7BfpDJaqbgrFSnu/674Eba93XgOLRBUq0FdZY5M=; b=nn2znEpB5pyM8z/41evVpFGuAtwtTBm+mKVHQDIusqSw4Ab13jaH6B+VsiptQ+ESEx ObRZ3mfOSss5SzZXQsOpvgUcH0tDrSnc91AkV76fB47JSS5bYC9ZoADdWK6sUBL5tcdf 3SYmeil5ScTnub9yWycV512NcuZklwoms/h+PRymSbixZ/AAsL5bnQYshK16inMCOQ9o 0jjeqQMacY9HkGPoeAVWyxV72L/jJtUs2Ks+DXdMcWDgDnnGq5Hnx67dztaQvwn+K18S y9iVkpXrPNH42/6Zwd82CPs7sauFjPHwLqLblGUVh4/zEoorHefeuiwu70Zd1Av/8a6K duwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FMww7BfpDJaqbgrFSnu/674Eba93XgOLRBUq0FdZY5M=; b=J9e69Yq+3UuZGHkzm3IxrvOS7L96vH4NPvPuRhUUCSBhUFTvt6FeWwYgfVcgDDjZKw xXiH1TjSS4xNzwpJyK/5S0thcBo0XhFFXY//yxMe09v1ITvXIyrchJn5s+X5r972We6x 4tF54QMnwG9ak+GWJCtNxiW2LtQsZK1k7BL+EhL6zhIo7guFM0CYcaKWUyAFcNugplgR 7JmKQ4eTrQT7OMSEIoYTMPeAp2bXEMpXIxkxiZ0/rXJzd7b/w34DoVrCDO2hF8WaRMwp +hp7o8CWybproFRY0YlgNFf6Fhb9J4eGo1MpBapd6cvt8VU1K/4hmlSrqTNf8OtZMKko nfBA== X-Gm-Message-State: APjAAAVo1KTBMgiFb8rP4fiGe9TPOVQHszGF5KRWXirdadH+K3VL/dp7 lZoQJ/lsHw86ryTNpR4oO/4= X-Google-Smtp-Source: APXvYqzTi8O5HVHhbpJ8fmpj4tB0SbxezVqZZrdGY5L/PebJB81f4q/8TYVkr94kfE6SO44I/vgDAQ== X-Received: by 2002:adf:de86:: with SMTP id w6mr26582541wrl.115.1575811370184; Sun, 08 Dec 2019 05:22:50 -0800 (PST) Received: from toaster (a.5.9.3.b.f.e.f.f.f.4.4.2.d.a.2.2.4.0.9.2.4.1.1.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1142:9042:2ad2:44ff:fefb:395a]) by smtp.gmail.com with ESMTPSA id c1sm9559049wmk.22.2019.12.08.05.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Dec 2019 05:22:49 -0800 (PST) Date: Sun, 8 Dec 2019 13:22:47 +0000 From: Adam Thompson To: Geoff McLane Cc: Dominique Martinet , "alf.siciliano@gmail.com" , edbrowse-dev@edbrowse.org Subject: Re: [edbrowse-dev] tidySetOptBool vs tidySetOptInt on debian Message-ID: <20191208132247.GE194728@toaster> References: <20191207171534.GA194728@toaster> <20191207184354.GA5418@nautica> <20191207200147.ca1a7b961f790d11feab8fe7@gmail.com> <20191207193433.GA15586@nautica> <20191207194928.GD194728@toaster> <20191207224543.ec830db69d404376505a33ea@gmail.com> <20191207221625.GA12745@nautica> X-BeenThere: edbrowse-dev@edbrowse.org List-Id: Edbrowse Development List MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) On Sun, Dec 08, 2019 at 03:29:04AM +0100, Geoff McLane wrote: > So sorry for the role 'libTidy' plays in this... > > Since it was introduced, circa 2017, the option 'TidyStyleTags' is a > boolean... ie use 'tidyOptSetBool'... No change is allowed... even if it > works... no ifdef whatever... since commit [1]... full stop... That's what I thought which is why this was so odd. > When linking, the installed version of tidy, through 'FindTidy.cmake', when > found, and used, it is of paramount importance, that the installed > 'lbtidy-dev', namely the headers, are of the /SAME/ version... > > That is the tidy.h, which includes tidyenum.h, are of the /SAME/ version as > the shared library found... not very easy to determine... > > Else there will be 'assert' problems in the non-release build, and unknown, > untold, unseen, problems otherwise... Yes... I had a closer look at the state of the system. Turns out that, whereas the library versions appeared to be correct in terms of linking (tidy 5 for both) it was somehow finding headers from a different version of tidy5 compiled from the git repo... Sorry for not noticing the old headers (thought I'd deleted those). I wonder if there's a version/release date in the headers anywhere which can be used, when debugging such issues, to tell such things? To be specific: on debian the tidy5 headers live in /usr/include/tidy whereas the standard install location for compiled tidy5 from git would appear to be /usr/local/include. As another question, why is TidyBodyOnly an option which takes a bool as an argument but tidySetOptInt is used to set it? Cheers, Adam. PS: Appologies again for not noticing the system was in an... odd... state.