From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by hurricane.the-brannons.com (Postfix) with ESMTPS id B75577B1DB for ; Thu, 16 Jan 2020 12:28:42 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id t2so20534273wrr.1 for ; Thu, 16 Jan 2020 12:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LA7zLYjf846Jk6t96VvbYLlis06RQ+5t6AvpSW7NuOo=; b=OxkMD3bTlfCw4vtkWqbt/2vC/bF9wDUI8a3xavpwCjp8eIapXwEQrIINSNvH/b9zNy o/u1q9emEhrzFKkaKEcHEwsikETYa5QYPbVSuvoG6i7+MWwNp26qbFN67w17Y3tB4Mrv w7zP7E6OHNWOdicahMaG0Wq7d7W6tqKFvmz3rn7gCXdYKrwZO5sOm9J3M7gWsbd5HI8Z ERFWQXHYsRfjCQ/wZojuVwlPRnzMI/iTwM6ycdd2rWg15r5fqOhajocsPBgVUsak+kqC ha7GK+t+HhZpRk47xV4nbxYMXZwanljxrYSHq42/b35BuOA0moh5S+G+cIoymdX391Q4 J8dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LA7zLYjf846Jk6t96VvbYLlis06RQ+5t6AvpSW7NuOo=; b=e23CkIbqS+dqX8Pv7HwBCIVZ6yhcB09CEpkn7OXoZVB1kwx138Owa5wyD1ie6EpTms u6UTrQGAJAmd/2t0magVCuZiefxg92/XanWfm7biElLV945IS4x8R/LtMgRGcHDWKCR+ 8OVeBAdeXkum7eeH4TV+z+MIjAAoFHGefDRpSWS1Ds8f14zjyEnYmt3XQYu0mAU0yT8D vv9YDbZejmf7ROVecXPpgB6qjlg5s5oznOKDmKU3qTJDlD/D6dwISAeA6szfTq5PeI28 JUh3swGVW9B01B1tgrWYIo0GHpc/+7QdeqnmRYpU75eZ/pPDcR0acu0QjfG0y5Etq3es tJ5Q== X-Gm-Message-State: APjAAAUN9GVkcTQhh0RB6n3756MsfMv8EghAsyh5gLmsh2vrLKO8NsJ0 Wb8ixLuUMLg38yrxkpZeJR0= X-Google-Smtp-Source: APXvYqw0urZeRMpA9UlJctJOLhWsnqSVLsuwp3hvuHOdys6JzCCefF1SA7KAg/vdIne5fMqeWdOY9g== X-Received: by 2002:a5d:50d2:: with SMTP id f18mr5121123wrt.366.1579206520650; Thu, 16 Jan 2020 12:28:40 -0800 (PST) Received: from toaster (a.5.9.3.b.f.e.f.f.f.4.4.2.d.a.2.2.4.0.9.2.4.1.1.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1142:9042:2ad2:44ff:fefb:395a]) by smtp.gmail.com with ESMTPSA id s8sm29825001wrt.57.2020.01.16.12.28.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 12:28:39 -0800 (PST) Date: Thu, 16 Jan 2020 20:28:38 +0000 From: Adam Thompson To: Geoff McLane Cc: "alf.siciliano@gmail.com" , edbrowse-dev@edbrowse.org, Dominique Martinet Subject: Re: [edbrowse-dev] documentation respecting install prefix in cmake Message-ID: <20200116202838.GH3451335@toaster> References: <20191225133640.GA74927@toaster> <20191225134715.GA11932@nautica> <20191225140551.GB93806@toaster> <20191225162952.GA2846@nautica> <9247904b-0fb1-95c4-18cb-86f279dbfc98@geoffair.info> <20191226184323.GA4808@toaster> <460ad829-de45-7788-f776-bcd37c65a0de@geoffair.info> <20191226205100.GA26919@nautica> <20191227165800.7bdad9dd717c43b644a81f79@gmail.com> <91f77e4e-865c-182a-5f66-950c685025a8@geoffair.info> X-BeenThere: edbrowse-dev@edbrowse.org List-Id: Edbrowse Development List MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <91f77e4e-865c-182a-5f66-950c685025a8@geoffair.info> Been a while, where did we get to on this? I don't see any update in the repo. Did we ever take the patch or did someone (who?) need to do something? On Fri, Dec 27, 2019 at 09:26:48PM +0100, Geoff McLane wrote: > Hi Dominique, Adam, Alfonso, > > Thanks for the holiday wishes... you all, enjoy... > > I might not know unix very well, but trying to continue to learn... > but I do know cmake quite well, for quite a long time... over many > cmake versions, back before say 2.6.4 of circa 2009... > > And I reminded myself of why even - >     set (UnixManDir "${CMAKE_INSTALL_PREFIX}/share/man/man1") >     set (UnixDocDir "${CMAKE_INSTALL_PREFIX}/share/doc/edbrowse") > is wrong... > > Not quite as wrong as - >     set (UnixManDir "/usr/share/man/man1") >     set (UnixDocDir "/usr/share/doc/edbrowse") > but still wrong, in principal... > > The CMake principal: > > If the path, in the cmake install line, after the keyword DESTINATION, > begins with a forward slash, /, then cmake will treat it as an > absolute path... > > And thus when generating the cmake_install.cmake will > add a warning/error, if asked with > -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION... > about using an absolute path... so devs can check before installs... > > This condition should be avoided, even if your patch does generate an > acceptable > absolute path... > > This should be a relative path, to the CMAKE_INSTALL_PREFIX, like >     set (UnixManDir "share/man/man1") >     set (UnixDocDir "share/doc/edbrowse") > > And yes, that relative path can be adjusted for specific distros... like > add/sub > the 'share' part, if need be, but always remain relative to the /ROOT/... > > Then the ugly cmake warning/error is /not/ generated... and all install > files goto the CMAKE_INSTALL_PREFIX... what ever the distro default, > or user choice, is... and nowhere else... > > And now begin to think even html tidy's use of MAN_INSTALL_DIR is > also not quite right... but seems to work, without the absolute > message... but now do /NOT/ suggest it... > > And yes, this is all tied up to the auto-make tools, which have > ENV vars, like MANDIR, DOCDIR, ..., which can still be used... > with cmake... > > Which leads to the GNUInstallDirs, with monstrosities like > CMAKE_INSTALL_MANDIR and CMAKE_INSTALL_DOCDIR... and/or, as > Alfonso suggests, maybe CMAKE_INSTALL_FULL_MANDIR/DOCDIR... which > again seems best to avoid... > > So I think edbrowse CMakeLists.txt should stick to using a > simple relative path only... for maximum compatibility... > > Anyway, that's my added 2 cents... ;=)) > > Regards, Geoff. >