From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (unknown [IPv6:2602:b8:6489:8a00::35bb:7ca9]) by hurricane.the-brannons.com (Postfix) with ESMTPSA id 745DE77FF6; Wed, 12 Jul 2017 05:26:30 -0700 (PDT) From: Chris Brannon To: Dominique Martinet Cc: Edbrowse-dev@lists.the-brannons.com References: <20170703051927.GA1994@nautica> <20170709144030.GA24038@nautica> <20170609174513.eklhad@comcast.net> <20170710045636.GA3943@nautica> <87tw2joaop.fsf@the-brannons.com> <20170712061115.GA3270@nautica> Date: Wed, 12 Jul 2017 05:27:18 -0700 In-Reply-To: <20170712061115.GA3270@nautica> (Dominique Martinet's message of "Wed, 12 Jul 2017 08:11:15 +0200") Message-ID: <874luhon6h.fsf@the-brannons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Edbrowse-dev] Disabling local echo for password fields X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 12:26:30 -0000 Dominique Martinet writes: > I have done just that: removed inp_types in html.c and declared as > extern in eb.h > I think 'number' might also need to be moved to minor, but did not take > the time to change that. I think the itype_minor idea is a good one, because all these minor types are just text for the purposes of edbrowse. We can add new ones if we ever need to do that; they'll still be handled as text. The thing I'm a little concerned about is the loss of information. I didn't really think this through when I read your patches yesterday. When ipass is used successfully to edit a form field, its itype_minor automatically becomes INP_PW. That loses the old itype_minor. There may be cases where we need it, E.G., for the DOM. For instance, what if some JS code needs to find the fields having type "email"? This is a bit contrived. Perhaps we should add a "maskedText" flag to struct htmlTag, set that in ipass, and use it to determine whether or not to print the stars for masked fields? Or maybe my concern is overblown, I don't know. Sorry for being a harsh reviewer. I really do like your work, and I want to see it merged. -- Chris