* [Edbrowse-dev] fwd: [Geoff McLane] Re: getting some traction on https://github.com/htacg/tidy-html5/issues/65
@ 2015-09-17 18:44 Chris Brannon
2015-09-17 19:29 ` [Edbrowse-dev] [Geoff McLane] getting some traction on Karl Dahlke
0 siblings, 1 reply; 6+ messages in thread
From: Chris Brannon @ 2015-09-17 18:44 UTC (permalink / raw)
To: edbrowse-dev
[-- Attachment #0: Type: message/rfc822, Size: 4343 bytes --]
From: Geoff McLane <ubuntu@geoffair.info>
To: public-htacg@w3.org
Subject: Re: getting some traction on https://github.com/htacg/tidy-html5/issues/65
Date: Thu, 17 Sep 2015 20:16:06 +0200
Message-ID: <55FB0366.1080401@geoffair.info>
Hi Chris,
As put on the Issue #65 posts, this fix is now in the issue-65 branch...
After some testing time, will be merged into master...
Would be great if you could pull and build this branch, and see if it
lives up to your expectations ;=))
Regards,
Geoff
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Edbrowse-dev] [Geoff McLane] getting some traction on...
2015-09-17 18:44 [Edbrowse-dev] fwd: [Geoff McLane] Re: getting some traction on https://github.com/htacg/tidy-html5/issues/65 Chris Brannon
@ 2015-09-17 19:29 ` Karl Dahlke
2015-09-17 21:32 ` Chris Brannon
0 siblings, 1 reply; 6+ messages in thread
From: Karl Dahlke @ 2015-09-17 19:29 UTC (permalink / raw)
To: edbrowse-dev
You can completely cut out my preprocessing by commenting out line 131 in html-tidy.c.
That leaves just tidy, to test
var a = "<script";
Karl Dahlke
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Edbrowse-dev] [Geoff McLane] getting some traction on...
2015-09-17 19:29 ` [Edbrowse-dev] [Geoff McLane] getting some traction on Karl Dahlke
@ 2015-09-17 21:32 ` Chris Brannon
2015-09-17 21:45 ` Karl Dahlke
0 siblings, 1 reply; 6+ messages in thread
From: Chris Brannon @ 2015-09-17 21:32 UTC (permalink / raw)
To: edbrowse-dev
Karl Dahlke <eklhad@comcast.net> writes:
> You can completely cut out my preprocessing by commenting out line 131 in html-tidy.c.
> That leaves just tidy, to test
Ok, so here's what people need to do if they want to test the tidy code.
First, pull their repo, check out the issue-65 branch, and build from
that instead of master.
Next, pull edbrowse. I've added some ifdef blocks that will let you
test the experimental code. Rebuild edbrowse, but pass
-DHAVE_TIDYSKIPQUOTES in CFLAGS, like so:
CFLAGS='-DHAVE_TIDYSKIPQUOTES' make
So here's what I've discovered so far.
Their fix works beautifully on the basic testcases, both the one in the
tidy 5 tests/ subdirectory and the one that Karl posted the other day.
But I tried it on a cached page from the fanfiction site, and it is
still having some kind of problem. Next step: figure out where it's
breaking now and see if we can come up with another test case.
-- Chris
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Edbrowse-dev] [Geoff McLane] getting some traction on...
2015-09-17 21:32 ` Chris Brannon
@ 2015-09-17 21:45 ` Karl Dahlke
2015-09-18 23:36 ` Chris Brannon
0 siblings, 1 reply; 6+ messages in thread
From: Karl Dahlke @ 2015-09-17 21:45 UTC (permalink / raw)
To: edbrowse-dev
Remember there is a second related bug:
var a = "<\/script>";
tsp and I tracked this one down.
fanfiction.net shows both bugs.
So does fictionpress.com.
Karl Dahlke
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Edbrowse-dev] [Geoff McLane] getting some traction on...
2015-09-17 21:45 ` Karl Dahlke
@ 2015-09-18 23:36 ` Chris Brannon
2015-09-19 1:05 ` Karl Dahlke
0 siblings, 1 reply; 6+ messages in thread
From: Chris Brannon @ 2015-09-18 23:36 UTC (permalink / raw)
To: edbrowse-dev
Karl Dahlke <eklhad@comcast.net> writes:
> Remember there is a second related bug:
>
> var a = "<\/script>";
And a third:
document.write('<style>body{font-family:"'+XCOOKIE.gui_font+'",Verdana, Arial;}</style>');
Taken from Tyler's fanfiction site...
-- Chris
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Edbrowse-dev] [Geoff McLane] getting some traction on...
2015-09-18 23:36 ` Chris Brannon
@ 2015-09-19 1:05 ` Karl Dahlke
0 siblings, 0 replies; 6+ messages in thread
From: Karl Dahlke @ 2015-09-19 1:05 UTC (permalink / raw)
To: edbrowse-dev
> document.write('<style>body{font-family:"'+XCOOKIE.gui_font+'",Verdana, Arial;}</style>');
These things generate tidy errors but usually don't derail the script
or the correct parsing of the page.
In fact every </foo inside a javascript becomes an error
and is converted into <\/foo, but usually causes no trouble.
var a = "</style>";
Karl Dahlke
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-19 1:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-17 18:44 [Edbrowse-dev] fwd: [Geoff McLane] Re: getting some traction on https://github.com/htacg/tidy-html5/issues/65 Chris Brannon
2015-09-17 19:29 ` [Edbrowse-dev] [Geoff McLane] getting some traction on Karl Dahlke
2015-09-17 21:32 ` Chris Brannon
2015-09-17 21:45 ` Karl Dahlke
2015-09-18 23:36 ` Chris Brannon
2015-09-19 1:05 ` Karl Dahlke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).