From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <chris@the-brannons.com>
Received: from localhost (unknown [IPv6:2602:b8:6489:8a00::35bb:7ca9])
 by hurricane.the-brannons.com (Postfix) with ESMTPSA id 96A8C77FF6;
 Wed, 12 Jul 2017 07:32:00 -0700 (PDT)
From: Chris Brannon <chris@the-brannons.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: Edbrowse-dev@lists.the-brannons.com
References: <20170703051927.GA1994@nautica> <20170709144030.GA24038@nautica>
 <20170609174513.eklhad@comcast.net> <20170710045636.GA3943@nautica>
 <87tw2joaop.fsf@the-brannons.com> <20170712061115.GA3270@nautica>
 <874luhon6h.fsf@the-brannons.com> <20170712125527.GB2295@nautica>
Date: Wed, 12 Jul 2017 07:32:48 -0700
In-Reply-To: <20170712125527.GB2295@nautica> (Dominique Martinet's message of
 "Wed, 12 Jul 2017 14:55:27 +0200")
Message-ID: <87wp7dn2sv.fsf@the-brannons.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Edbrowse-dev] Disabling local echo for password fields
X-BeenThere: edbrowse-dev@lists.the-brannons.com
X-Mailman-Version: 2.1.24
Precedence: list
List-Id: Edbrowse Development List <edbrowse-dev.lists.the-brannons.com>
List-Unsubscribe: <http://lists.the-brannons.com/mailman/options/edbrowse-dev>, 
 <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=unsubscribe>
List-Archive: <http://lists.the-brannons.com/mailman/private/edbrowse-dev/>
List-Post: <mailto:edbrowse-dev@lists.the-brannons.com>
List-Help: <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=help>
List-Subscribe: <http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev>, 
 <mailto:edbrowse-dev-request@lists.the-brannons.com?subject=subscribe>
X-List-Received-Date: Wed, 12 Jul 2017 14:32:00 -0000

Dominique Martinet <asmadeus@codewreck.org> writes:

> There is no "unmask" or "print anyway" command that would do that.

Yes, we can always add an unmask command if we really need it, and it'd
just clear the bit.

I also noticed that when parsing input elements that have type="text",
itype_minor is never set.  So for <input type="text"> it's always 0 (which
corresponds to INP_DATE).  I'd say we need a "default" placeholder at
the end of the minor types enum, to specify that this element is plain
old "text", and htmlInputHelper() from decorate.c should look something
like this:

void htmlInputHelper(struct htmlTag *t)
{
	int n = INP_TEXT;
	int len;
	char *myname = (t->name ? t->name : t->id);
	const char *s = attribVal(t, "type");
	if (stringEqual(t->info->name, "button")) {
		n = INP_BUTTON;
	} else if (s) {
		n = stringInListCI(inp_types, s);
		if (n == INP_TEXT) {
			t->itype_minor = INP_DEFAULTMINOR;
		}

Also, when the type was not found in inp_types nor inp_others,
itype_minor should probably be set to INP_DEFAULTMINOR (or whatever you
care to call it).

-- Chris