From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (unknown [IPv6:2602:4b:a4d8:4b00:12bf:48ff:fe7c:5584]) by hurricane.the-brannons.com (Postfix) with ESMTPSA id 2120D77894 for ; Wed, 29 Jan 2014 15:41:47 -0800 (PST) From: Chris Brannon To: Edbrowse Development References: <20140129134409.GG7404@toaster.adamthompson.me.uk> <871tzqmojl.fsf@mushroom.PK5001Z> Date: Wed, 29 Jan 2014 15:41:24 -0800 In-Reply-To: (Chuck Hallenbeck's message of "Wed, 29 Jan 2014 17:57:59 -0500") Message-ID: <87wqhil5jv.fsf@mushroom.PK5001Z> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Edbrowse-dev] compiling edbrowse with js24 X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.17 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2014 23:41:47 -0000 Chuck Hallenbeck writes: > Next question: If I modify the edbrowse makefile to add those flags, what > happens to my modifications when the makefile iks updated? Well, they get erased! So don't modify the makefile. I'd suggest a script like this one: #!/bin/sh # ebmake, build edbrowse # Expects to be run from the root of the edbrowse tree, LDFLAGS=-L/usr/local/lib make JS_CXXFLAGS=/usr/local/include/mozjs-24 # End of script. This is sort of how we do things when packaging for distributions. Typically, we don't write patches against the makefile, because they're fragile. It's better to set variables or flip configure switches. Since edbrowse doesn't have a configure script, we end up setting environment variables, or in the case of JS_CXXFLAGS, "make" variables. Don't make the mistake of using JS_CXXFLAGS as an environment variable, because make will override it. Instead, it needs to be passed after the make command, so make will do the substitution: make JS_CXXFLAGS=whatever -- Chris