edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Geoff McLane <ubuntu@geoffair.info>
To: Dominique Martinet <asmadeus@codewreck.org>,
	Adam Thompson <arthompson1990@gmail.com>
Cc: edbrowse-dev@edbrowse.org
Subject: Re: [edbrowse-dev] documentation respecting install prefix in cmake
Date: Wed, 25 Dec 2019 18:42:48 +0100	[thread overview]
Message-ID: <9247904b-0fb1-95c4-18cb-86f279dbfc98@geoffair.info> (raw)
In-Reply-To: <20191225162952.GA2846@nautica>

Hi Adam,

Yes, I add my own CMAKE_INSTALL_PREFIX, to my $HOME directory...
but see, in the output, if I do `$ sudo make install`,
  `-- Installing: /usr/share/man/man1/edbrowse.1.gz`,
so it seems, when CMake generates the `Unix Makfile` build, it has
chosen other than my suggested install directory... for this `man`
component... hmmm, why? That is NOT GOOD...

I can see, in that `UNIX Makfile` generation, it also gens
a `cmake_install.cmake`, and runs cmake on that if given the `install` 

And as pointed out, this is HARD CODED in the CMakeLists.txt as -
if (UNIX)
     FILE (GLOB UnixManFile "doc/man-edbrowse-debian.1")
     set (UnixManDir "/usr/share/man/man1")
     set (UnixDocDir "/usr/share/doc/edbrowse")
     FILE (GLOB UnixManFile "doc/man-edbrowse-freebsd.1")
         set (UnixManDir "/usr/local/man/man1")
         set (UnixDocDir "/usr/local/share/doc/edbrowse")

Why so very HARD CODED defaults... That could be changed, modified, 
enhanced, etc...

In the html-tidy tidy.1 generation/install, we have a MAN_INSTALL_DIR 
override option,
but otherwise let cmake choose a default... which seems to default to -
so, without that override, honors the users CMAKE_INSTALL_PREFIX... the 
being "/usr/local"...

So I certainly think there could be some CMakeLists.txt patches here... will
try to experiment... soonest... suggestions welcome...

And Dominique, your patch does some of this, but still question why
does edbrowse wants to define its own target UnixManDir... cmake has 

what I mean... on install... no go...

As a developer, I need to be able to install-where-I-want,
100% ... to be able to check, inspect, try, test, ... even in 
and /NOTHING/ must be written /anywhere/ else... full stop...

So suggest the CMakeLists.txt patch go deeper... see html-tidy 
where we use the xsltproc generated, big tidy.1, and install it...

But Adam, do not fully understand your original comment -
 > that I specified the install prefix as /usr/local to avoid any issues 

First, as I understand it, that /IS/ the cmake default, so no need to 
add it...

But what do you mean by `issues with packages`! What issues, with what 
packages, are
you trying to avoid... maybe we can address those...

As an aside, it is certainly time to update the man-edbrowse-debian.1 line
.TH edbrowse 1 2018-05-01 "edbrowse 3.7.3"

But that is off topic...


Regards, Geoff.

  reply	other threads:[~2019-12-25 17:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-25 13:36 Adam Thompson
2019-12-25 13:47 ` Dominique Martinet
2019-12-25 14:05   ` Adam Thompson
2019-12-25 16:29     ` Dominique Martinet
2019-12-25 17:42       ` Geoff McLane [this message]
2019-12-26 18:43         ` Adam Thompson
2019-12-26 20:31           ` Geoff McLane
2019-12-26 20:51             ` Dominique Martinet
2019-12-27 15:58               ` alf.siciliano
2019-12-27 20:26                 ` Geoff McLane
2020-01-16 20:28                   ` Adam Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9247904b-0fb1-95c4-18cb-86f279dbfc98@geoffair.info \
    --to=ubuntu@geoffair.info \
    --cc=arthompson1990@gmail.com \
    --cc=asmadeus@codewreck.org \
    --cc=edbrowse-dev@edbrowse.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).