Re: [edbrowse-dev] documentation respecting install prefix in cmake

[Geoff McLane <ubuntu@geoffair.info>]

Hi Adam,

Yes, I add my own CMAKE_INSTALL_PREFIX, to my $HOME directory...
but see, in the output, if I do `$ sudo make install`,
  `-- Installing: /usr/share/man/man1/edbrowse.1.gz`,
so it seems, when CMake generates the `Unix Makfile` build, it has
chosen other than my suggested install directory... for this `man`
component... hmmm, why? That is NOT GOOD...

I can see, in that `UNIX Makfile` generation, it also gens
a `cmake_install.cmake`, and runs cmake on that if given the `install` 
target...

And as pointed out, this is HARD CODED in the CMakeLists.txt as -
if (UNIX)
     FILE (GLOB UnixManFile "doc/man-edbrowse-debian.1")
     set (UnixManDir "/usr/share/man/man1")
     set (UnixDocDir "/usr/share/doc/edbrowse")
     if (${CMAKE_SYSTEM_NAME} STREQUAL  "FreeBSD")
     FILE (GLOB UnixManFile "doc/man-edbrowse-freebsd.1")
         set (UnixManDir "/usr/local/man/man1")
         set (UnixDocDir "/usr/local/share/doc/edbrowse")
     endif()
...

Why so very HARD CODED defaults... That could be changed, modified, 
enhanced, etc...

In the html-tidy tidy.1 generation/install, we have a MAN_INSTALL_DIR 
override option,
but otherwise let cmake choose a default... which seems to default to -
"${CMAKE_INSTALL_PREFIX}/share/man/man1"
so, without that override, honors the users CMAKE_INSTALL_PREFIX... the 
default
being "/usr/local"...

So I certainly think there could be some CMakeLists.txt patches here... will
try to experiment... soonest... suggestions welcome...

And Dominique, your patch does some of this, but still question why
does edbrowse wants to define its own target UnixManDir... cmake has 
defaults
like MAN_INSTALL_DIR...

Try setting CMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION and you will see
what I mean... on install... no go...

As a developer, I need to be able to install-where-I-want,
100% ... to be able to check, inspect, try, test, ... even in 
/tmp/rubbish...
and /NOTHING/ must be written /anywhere/ else... full stop...

So suggest the CMakeLists.txt patch go deeper... see html-tidy 
CMakeList.txt,
where we use the xsltproc generated, big tidy.1, and install it...

But Adam, do not fully understand your original comment -
 > that I specified the install prefix as /usr/local to avoid any issues 
with
packages.

First, as I understand it, that /IS/ the cmake default, so no need to 
add it...

But what do you mean by `issues with packages`! What issues, with what 
packages, are
you trying to avoid... maybe we can address those...

As an aside, it is certainly time to update the man-edbrowse-debian.1 line
.TH edbrowse 1 2018-05-01 "edbrowse 3.7.3"

But that is off topic...

HTH,

Regards, Geoff.