From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by hurricane.the-brannons.com (Postfix) with ESMTPS id EB3A0791CA for ; Wed, 25 Dec 2019 09:42:52 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id t2so22129445wrr.1 for ; Wed, 25 Dec 2019 09:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geoffair-info.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=b2PyBCb0O4bDK2qyAF/PKLlzYV+Mul1aFe7DNIXukUg=; b=KLSmvrS0p4dHL5dDCvmQ1whWUyL75RyBRfB+8aHxuoHPRTAuHULQA96D44CLxyPJlu KsdbONz3J96IS2JLvZO735FjkWnVWCd+WEtyo/XLgKkREU+nYpaJ/OEyuItBv/Gr9bcw UHZlkuX6bOaMh8gz469gOVrgWwJAebLtB3p+wWqNB0ynBLxizh79KLZ175RMuLkjvOGp Qz/LOVYrPZ00QLclyN18Ml3SWHj7QMU7Fsf+/7Llx/6AsD/Ga6MxgV6YZL3CiVnqxpJr UqDYMbcX3kbo/EaFgPhnA1b+OGHUQdwnZrlUNOxooYTSJ9JGztmKVsEw5BOygWagUafn 1XlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=b2PyBCb0O4bDK2qyAF/PKLlzYV+Mul1aFe7DNIXukUg=; b=QH1XoXiWJEwqmPqBYt/VjdPUfl7DolOlCwaC5oEth2sl9G4gXHCd48Fv1ybUgu0CSd KiNiuj2Al39ST9qxCeC6Uk4NaozNvaTKIfXzvsRoeZgWKAwuOMzJQqtgIZ8RRSVGe1vx t5Ll8BB/8pYjgRvCIAmnMKcv5C8gWtdKmMTuXqNkYxmoewAvy+xVFPMUUpoJmVAEElC+ 1aIIr3+6ZE3icdWEkBXp5q4R0uY1tnNgXhiJBtU09DQJSAGcPAcVAwYyt124vsr0eZTu 4mXt/sHOLigZeZx3e0kh8uAs2LrnOndqgX/EAI+XyuVSrbJlow2p+8xjXeL6zvxcktjn R/Ag== X-Gm-Message-State: APjAAAWOBfXC4cZj3CjYlHR6wvk9W4yoY9Z5NSYOQixvVazbA0pNdUcJ l4DYGKnBuXvta0BIXLT8DZoSBCto6nI= X-Google-Smtp-Source: APXvYqwnmeucK+GK4KnCbtFBH6TuhTYP975ZKk2ry/NwkyRcBwpOx4RAZY4uOIpSWSxeVEEsJiGFOQ== X-Received: by 2002:adf:e887:: with SMTP id d7mr39723486wrm.162.1577295770256; Wed, 25 Dec 2019 09:42:50 -0800 (PST) Received: from ?IPv6:2a01:cb04:4ba:c500:e5fd:9373:431b:b5b3? (2a01cb0404bac500e5fd9373431bb5b3.ipv6.abo.wanadoo.fr. [2a01:cb04:4ba:c500:e5fd:9373:431b:b5b3]) by smtp.googlemail.com with ESMTPSA id s8sm27460831wrt.57.2019.12.25.09.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Dec 2019 09:42:49 -0800 (PST) Subject: Re: [edbrowse-dev] documentation respecting install prefix in cmake To: Dominique Martinet , Adam Thompson Cc: edbrowse-dev@edbrowse.org References: <20191225133640.GA74927@toaster> <20191225134715.GA11932@nautica> <20191225140551.GB93806@toaster> <20191225162952.GA2846@nautica> From: Geoff McLane Message-ID: <9247904b-0fb1-95c4-18cb-86f279dbfc98@geoffair.info> Date: Wed, 25 Dec 2019 18:42:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 X-BeenThere: edbrowse-dev@edbrowse.org List-Id: Edbrowse Development List MIME-Version: 1.0 In-Reply-To: <20191225162952.GA2846@nautica> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Hi Adam, Yes, I add my own CMAKE_INSTALL_PREFIX, to my $HOME directory... but see, in the output, if I do `$ sudo make install`,  `-- Installing: /usr/share/man/man1/edbrowse.1.gz`, so it seems, when CMake generates the `Unix Makfile` build, it has chosen other than my suggested install directory... for this `man` component... hmmm, why? That is NOT GOOD... I can see, in that `UNIX Makfile` generation, it also gens a `cmake_install.cmake`, and runs cmake on that if given the `install` target... And as pointed out, this is HARD CODED in the CMakeLists.txt as - if (UNIX)     FILE (GLOB UnixManFile "doc/man-edbrowse-debian.1")     set (UnixManDir "/usr/share/man/man1")     set (UnixDocDir "/usr/share/doc/edbrowse")     if (${CMAKE_SYSTEM_NAME} STREQUAL  "FreeBSD")     FILE (GLOB UnixManFile "doc/man-edbrowse-freebsd.1")         set (UnixManDir "/usr/local/man/man1")         set (UnixDocDir "/usr/local/share/doc/edbrowse")     endif() ... Why so very HARD CODED defaults... That could be changed, modified, enhanced, etc... In the html-tidy tidy.1 generation/install, we have a MAN_INSTALL_DIR override option, but otherwise let cmake choose a default... which seems to default to - "${CMAKE_INSTALL_PREFIX}/share/man/man1" so, without that override, honors the users CMAKE_INSTALL_PREFIX... the default being "/usr/local"... So I certainly think there could be some CMakeLists.txt patches here... will try to experiment... soonest... suggestions welcome... And Dominique, your patch does some of this, but still question why does edbrowse wants to define its own target UnixManDir... cmake has defaults like MAN_INSTALL_DIR... Try setting CMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION and you will see what I mean... on install... no go... As a developer, I need to be able to install-where-I-want, 100% ... to be able to check, inspect, try, test, ... even in /tmp/rubbish... and /NOTHING/ must be written /anywhere/ else... full stop... So suggest the CMakeLists.txt patch go deeper... see html-tidy CMakeList.txt, where we use the xsltproc generated, big tidy.1, and install it... But Adam, do not fully understand your original comment - > that I specified the install prefix as /usr/local to avoid any issues with packages. First, as I understand it, that /IS/ the cmake default, so no need to add it... But what do you mean by `issues with packages`! What issues, with what packages, are you trying to avoid... maybe we can address those... As an aside, it is certainly time to update the man-edbrowse-debian.1 line .TH edbrowse 1 2018-05-01 "edbrowse 3.7.3" But that is off topic... HTH, Regards, Geoff.