From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no
	version=3.4.4
Received: (qmail 12550 invoked from network); 7 Oct 2022 12:21:14 -0000
Received: from hurricane.the-brannons.com (2602:ff06:725:1:20::25)
  by inbox.vuxu.org with ESMTPUTF8; 7 Oct 2022 12:21:14 -0000
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by hurricane.the-brannons.com (OpenSMTPD) with ESMTP id 23a3f64b
	for <ml@inbox.vuxu.org>;
	Fri, 7 Oct 2022 05:21:09 -0700 (PDT)
Received: from nautica.notk.org (ipv6.notk.org [2001:41d0:1:7a93::1])
	by hurricane.the-brannons.com (OpenSMTPD) with ESMTPS id 074f9f98 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO)
	for <edbrowse-dev@edbrowse.org>;
	Fri, 7 Oct 2022 05:21:01 -0700 (PDT)
Received: by nautica.notk.org (Postfix, from userid 108)
	id B8517C01A; Fri,  7 Oct 2022 14:20:55 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2;
	t=1665145255; bh=Ho+R4ejHZ5fsK9ncaV6u75kHA03QMu/2nzHrUK8UBK8=;
	h=Date:From:To:Cc:Subject:From;
	b=0NGnPLMLvkMgFm2ChclpVY+FBqQ1XsUsx2lKFekcdZviUJDtx1jEM28EK7okMjfQ5
	 FJlSYuXkgJT2wMUAC5+Uhqmreemn8jSK/XrJpt5nIv/4EOZ5Hy2s3G/PSjR3+9VQZ9
	 9OKsmPWl1kRATZQRSMkQEs6L6VHGWKW3HCVI08ycai6XM1MjdBpJQ4an9l2hbqqh+L
	 M9tbtRqcx09k0mOrakkzadStq9vnOIYtIL7tjEnJagFMR6HiRp9jmCUyVO0w+D6UZU
	 GYPtPuyZUbvPWSGq79/afpLDhj+KYf+RJSCA8+Tnqltc3s+BG01oEhXMu7N9RaRjCb
	 ve4N0AE25xc2w==
Received: from odin.codewreck.org (localhost [127.0.0.1])
	by nautica.notk.org (Postfix) with ESMTPS id C8269C009;
	Fri,  7 Oct 2022 14:20:53 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2;
	t=1665145254; bh=Ho+R4ejHZ5fsK9ncaV6u75kHA03QMu/2nzHrUK8UBK8=;
	h=Date:From:To:Cc:Subject:From;
	b=ZJh3kvWXhwYLx/Sh2yqxbsKo+GXl1FAp3N2AOe95G6bBoACSZFL/vKK/N0X4UfvLZ
	 jYm5eWEaS1dJDUk9tUOvpP8J5ZTz7qmry/PLOtPocx6Nlq6ED8F0MlAxfYqOb/UT8A
	 fnfKXBLz+N5sThuMrzaJtrJLaRvP6VpBNolIl/E1r9raGfbda6pyA585jBuEIrbZGE
	 mPaPyX+O/ghVsFWgTaDGmx2t+qopbA2d3NXA4kj2aMzvfW5GpMSY4c7fVq49tOYn0K
	 4ysOUjUySZM0PFmKrGhGmxMH8dwoG2BELdK68wNP2L5raeYsZrBCNLebaR6YRJQHV0
	 iMZgzo9+dSnVg==
Received: from localhost (odin.codewreck.org [local])
	by odin.codewreck.org (OpenSMTPD) with ESMTPA id ef24d613;
	Fri, 7 Oct 2022 12:20:50 +0000 (UTC)
Date: Fri, 7 Oct 2022 21:20:35 +0900
From: Dominique Martinet <asmadeus@codewreck.org>
To: Karl Dahlke <eklhad@comcast.net>
Cc: edbrowse-dev@edbrowse.org
Subject: some js debugging...
Message-ID: <Y0AZk9yyQ838px81@codewreck.org>
X-BeenThere: edbrowse-dev@edbrowse.org
List-Id: Edbrowse Development List <edbrowse-dev.edbrowse.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline


Hi Karl,

I've done some real world debugging and would like help thinking on how
to fix these...
Unfortunately it's on an internal (work), so I can't share any example
unless I try to make one :/

It's using jquery under the hood so something we must try to understand.

I'm looking at this (readable) version :
https://code.jquery.com/jquery-2.2.4.js


In the order I stumbled uppon problems:
1/ the first is outside that file, but they do getElementsByTagName()
to get a form <select> field, then var $select = jQuery(select); and
$select.prop('disabled') should apparently be false.
It's undefined for us, we can probably just add it to Option in
startwindow.js with this.disabled = false? I have not checked yet where
that should be true.

2/ next in jquery-2.2.4.js, line 7648, this option.disabled should also
be false. It'll probably be fixed with the same fix...
But then on the next line we have option.parentNode.disabled.
option is elem.options[3], and for edbrowse option.parentNode is elem.options,
but for firefox option.parentNode is elem.
We probably want to do the same, I'm not sure where we chose the parent.

3/ then Sizzle.attr line 1446
First something probably minor, but elem.ownerDocument is not defined
and on firefox it is 'document', we probably want to set that in Option
creation as well (they setDocument on the item if not, not sure what
that does in practice)
Then some weird expression I don't understand, but it's undefined and we
want that here so it's good, until elem.getAttribute("value") does not
return elem.value
That can probably be fixed in shared.js doing like we do with length and
returning this.value directly if name === "value".

4/ another unrelated problem I have is when the site apparently decided
to add an onclick event on the td of a table (via jquery data-event /
data-handler; not sure how that works but I could reproduce with
onclick)
You can try it here:
https://gaia.codewreck.org/local/tmp/link-td.html
Both "Test 1" and "Test 2" pop up an alert when clicked (they are
stylized differently but that doesn't matter, the text is clickable and
runs js)
Apparently that can be set for tr as well in which case the whole row
would be clickable anywhere in the row, and I tried for giggles but that
applies anywhere up: the table, or even body! Not sure what we'd want to
do out of that, but tr and td seem common enough that we want to come up
with a way to interact with them (and I need td with href=# for my
internal site)



I've pushed some fixes in https://github.com/martinetd/edbrowse master
branch, that fix 1/ and 3/ and it seems to work leaving a workaround for
parentNode in the site's code, but I'm not quite sure what to do with
parentNode and actions at table level.


I've also added two unrelated patches:
 - one fixes some memory leaks, there might be some left but I got a
few
 - other one fixes more (probably not very useful) gcc warnings, but at
least that makes my compilation less verbose
If you prefer to look at these separately I can remove them for now.


Cheers!
--
Dominique