From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out.smtp-auth.no-ip.com (smtp-auth.no-ip.com [8.23.224.60])
	by hurricane.the-brannons.com (Postfix) with ESMTPS id 396E977BBB
	for <edbrowse-dev@lists.the-brannons.com>; Sun, 16 Jun 2019 21:10:47 -0700 (PDT)
X-No-IP: carhart.net@noip-smtp
X-Report-Spam-To: abuse@no-ip.com
Received: from carhart.net (unknown [99.57.137.251])
	(Authenticated sender: carhart.net@noip-smtp)
	by smtp-auth.no-ip.com (Postfix) with ESMTPA id BA39337FB2F
	for <edbrowse-dev@lists.the-brannons.com>; Sun, 16 Jun 2019 21:10:46 -0700 (PDT)
Received: from localhost (kevin@localhost)
	by carhart.net (8.15.2/8.15.2) with ESMTP id x5H4Ai7O045253
	for <edbrowse-dev@lists.the-brannons.com>; Sun, 16 Jun 2019 21:10:44 -0700
Date: Sun, 16 Jun 2019 21:10:44 -0700 (PDT)
From: Kevin Carhart <kevin@carhart.net>
To: edbrowse-dev@lists.the-brannons.com
Subject: [edbrowse-dev] [PATCH] element.dataset and h/w dimension properties added to element prototype
Message-ID: <alpine.DEB.2.21.1906162102320.43864@carhart.net>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
X-BeenThere: edbrowse-dev@edbrowse.org
List-Id: Edbrowse Development List <edbrowse-dev.edbrowse.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-1463766271-1139975899-1560744644=:43864"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463766271-1139975899-1560744644=:43864
Content-Type: text/plain; format=flowed; charset=US-ASCII

I can't use edbrowse sm at the moment so in case alpine adds bad 
linefeeds, please refer to the attached

>From c5653a8493bf6bf898355431b6fbc1ebcc09e566 Mon Sep 17 00:00:00 2001
From: Kevin Carhart <kevin@carhart.net>
Date: Sun, 16 Jun 2019 19:55:10 -0700
Subject: [PATCH] Makes html data-* attributes available in element.dataset
  object.  Also adds screen dimension properties to element.prototype.

---
  src/decorate.c     | 12 ++++++++++++
  src/jsrt           |  4 +++-
  src/startwindow.js |  8 ++++++++
  3 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/src/decorate.c b/src/decorate.c
index 52e2459..c9ad47a 100644
--- a/src/decorate.c
+++ b/src/decorate.c
@@ -937,6 +937,7 @@ static void domLink(struct htmlTag *t, const char *classname,	/* instantiate thi
  	const char *stylestring = attribVal(t, "style");
  	jsobjtype so = 0;	/* obj.style */
  	jsobjtype ato = 0;	/* obj.attributes */
+	jsobjtype dso = 0;	/* obj.dataset */
  	char upname[MAXTAGNAME];

  	debugPrint(5, "domLink %s.%d name %s",
@@ -1043,6 +1044,8 @@ Don't do any of this if the tag is itself <style>. */
  		ato = instantiate(io, "attributes", "NamedNodeMap");
  		set_property_object(ato, "owner", io);
  		set_property_object(io, "ownerDocument", cf->docobj);
+                dso = instantiate(io, "dataset","Object");
+                set_property_object(io,"dataset",dso);

  // only anchors with href go into links[]
  		if (list && stringEqual(list, "links") &&
@@ -1549,6 +1552,15 @@ static void pushAttributes(const struct htmlTag *t)
  	if (!a)
  		return;
  	for (i = 0; a[i]; ++i) {
+
+// attributes on HTML tags that begin with "data-" should be available under a 
+// "dataset" object in JS
+	if (strncmp(a[i],"data-",5)==0) {
+	jsobjtype dso = get_property_object(t->jv,"dataset");
+	if(dso)
+		set_property_string(dso, a[i]+5, v[i]);
+	}
+
  // There are some exceptions, some attributes that we handle individually.
  		static const char *const exclist[] = {
  			"name", "id", "class",
diff --git a/src/jsrt b/src/jsrt
index 22507f4..4ce72fd 100644
--- a/src/jsrt
+++ b/src/jsrt
@@ -499,7 +499,7 @@ We'll get back to you if we like what you have to say.
  <input type='submit' value='Send Message' name='b1'
  onclick="alert('rock and roll')">
  </form>
-
+<DIV id=tag_with_data_attribute data-blech=abc>ok</DIV>
  <script type=text/javascript language=JavaScript>
  // I'll push the button for you
  document.forms[0].b.onclick();
@@ -892,6 +892,8 @@ if(fn.contentDocument.style.bgcolor !== "white") fail(168);
  if(querySelector(".inject").firstChild.style.display != "round") fail(175);
  if(document.body.style.fly) fail(176);

+var dataset_test = document.getElementById("tag_with_data_attribute");
+if(dataset_test.dataset.blech !== "abc") fail(177);
  </script>

  </body>
diff --git a/src/startwindow.js b/src/startwindow.js
index 5b1d4fc..589622b 100644
--- a/src/startwindow.js
+++ b/src/startwindow.js
@@ -2498,6 +2498,14 @@ set: function(s) { return mw0.newTextUnder(this, s, 1); }});
  Object.defineProperty(c.prototype, "nodeValue", {
  get: function() { return this.nodeType == 3 ? this.data : null;},
  set: function(h) { if(this.nodeType == 3) this.data = h; }});
+c.prototype.clientHeight = 16;
+c.prototype.clientWidth = 120;
+c.prototype.offsetHeight = 16;
+c.prototype.offsetWidth = 120;
+c.prototype.scrollHeight = 16;
+c.prototype.scrollWidth = 120;
+c.prototype.scrollTop = 0;
+c.prototype.scrollLeft = 0;
  }
  })();

-- 
1.8.3.2

---1463766271-1139975899-1560744644=:43864
Content-Type: application/zip; name=kc_20190616.zip
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.DEB.2.21.1906162110440.43864@carhart.net>
Content-Description: 
Content-Disposition: attachment; filename=kc_20190616.zip

UEsDBBQAAAAIAF2f0E55qLO4YwYAAAQNAAARABwAa2NfMjAxOTA2MTYucGF0
Y2hVVAkAA/IBB13yAQdddXgLAAEEAAAAAAQAAAAAhVZtc9pIEv5s/YpeqnYR
BoQEiBfbsPEl2UuycS5V9mWvyuVy6WWExhYSK40g1K7/+z49IoDBrqNcljTT
3dP9dPfT81uezSlwB27PG/XHPT8a+NFoPOq5br/n+IPIDxzhB4E9Fu5gQFdZ
StdiQc6QbPtM/1HXth3jN5g5o9/FUqb01stjL1d08cifb4Lq00qFmhrvPCXO
6LpMW+QM6FOZQt0ZkzM+c90zx6a2PbRt47r0H0Sgzuj26+XN2w93dOU9ioJi
NU8o9JTXPiVPqVz6pcKyt/Rk4vmJIBwuEjEXqbJYrBDKoEybsogukyIjLwwL
KoJciJRCCclCIqRFni1EriSMqWxrAqsqU+uFsAyj3W4bVORBJxRBliMIKyD+
/U1Ol5p7v0rqoUD8u9/fRH2W2tgoFPBYyTTMVtZDwbsj2un3KJIJPAliL52J
sEXdHgIr2L8sLcxmA9BRCCf522w3DCOUUUTt9kwq8joHTvoHCwaOFd/J7Ypu
3x1bVjD2wv7QI8e2B/0+x3lkw4Bbx3bevKH2uDdsDajJjyFhAYEpGdAykyGF
2fyzTB/NQuVloHTubrwZnaoWBYhDcXw5nQaJVxSpNxetk84px6m8VEkcQSqW
Bp3syxZqDWCQ93RGk00FfPMSEyZreq/WOIfKQ4Gcc94ICZ+Qfc6WsWRpGTrt
PJPx1HOhvcKCZHNPMjwwtymxyqD2sFxwJLdXl/+7ufz3l8ur93fwB5uh8MvZ
V/itTBe+bqChnwvr55BYBa+1lobUsfs9xhTPfmvEoL7L0roCnOSla8oixqUg
yU9gBET5SxUiiehCBzi1Ko9Oqsj2IDVlhtN3Adbw9QWnh1+yUFx5iwq+E8R0
v+mI9X3VPiZsQThbpSKHlsxel5RbwXdZUHIjQSGI2tMwCyACxSYd/Cpgjxzd
4Ftr1f6jTdde0n3FhZ0yjDd0FjodytJkDRiDOMsLWkkVU5yLiGYZDgdYCZJS
3N5xZMDXTCQq75dfqKq493+WKDVeg2tastbAbpU0tz/WSXPdbstxD1thURbx
5RZ1syrpo75o4Fw+9ieP305yoco8ZZijLCdT6tIj71benYMsZIP+MppGE0Ht
FSyo7MPN1WcuCzBZ7CnyxQykqEPVkLRrVMRZmYTY2SPOEqSQk0fa4Ba7DXcy
rX66Riuwd3A7DeYLkx1pbUy23MZkYmuPjtpl9kJ+VHv6sNyliNMK2yZnCm/P
q6oCn/daOvgmGmiJp1Z6AgSc15tY5Agn545HM4nvgVhotmxVC3sQaVRWgkCu
oZ4YoVzKEKlN1pYu6SpvzyhKv8MoJ//2DkH9xZInNe5c7iEZ8n/NZOjiIzbW
w8Dfvm4YuNt17WHUt6x+IIbdKDxmYC284179ydXWH49Bt83qgYU/RD1JGGjy
veCRJ9g6K5khEGYiHwWtOGZei72l4P3C42AvZLooFXGyJvWi9OdS1WnpJSU+
r0Ua0pUoCm8m6pqiJnXfqWOcpoAheJzUvAT5Met5hiOBJeVZktQbtSnsdlCx
86nRNpoX7z5+IxlOUJD3XIT3nPP7bTqqYY4CDOKJ5wfT7PGiAw22gRktFxvn
lPiuOg+o1s1igsFYwrHJJ6xd67WproOPDAR3myZHnKDQEdw+CN4AhVZ8ZLF7
xa19Z/nWJhwT5cTQjsZd7mN+aO5FVUaphQJQ0PvBZ9UcsfxZkCWw/dNkQrVV
LBXGD0XoKNMZjJhyoPxnKfL1NWZ1oLLcrFkyrYjMimReqLexTMKNtVAWi8Rb
wxrV8gz9uDU2dDfGtv77WbjeqEXJeis30DzXXKJmN611j4pXqNetJorkfXW7
+df6Y2jWXsmLbkk+cc/Mj3Fn6XRVUSNnOzeHfPxFp/iRD/5gT6fHHXFwAfJf
WPxxT/GdsB8FluWOxoNu1z/ukgO1Xb8cbHB6u/3xiPOrn05f87TANTMq00Df
pgqQGFXMS/OVjTvr6gbF91+mR5MHLwgF16/GOT09cbjVYLJCEclUfN1wlhns
ro7ghRTD9Rt3FUgCxDF7duDeeWzeYuEbZk/A26Nfq0VGns4oLZPk/KllHPgc
sw0k61i/sac+oXjjdHPPPQvVj2L4IOQs5kJxBi/u/yFDDBBsd+2D/SyK4M3r
+tX+6/qoFvDG6/rV/v/Tv8kWejy+tPdZRKrapCf8NUzdJSgfw7FGVs/qGsY/
UEsBAh4DFAAAAAgAXZ/QTnmos7hjBgAABA0AABEAGAAAAAAAAQAAAKSBAAAA
AGtjXzIwMTkwNjE2LnBhdGNoVVQFAAPyAQdddXgLAAEEAAAAAAQAAAAAUEsF
BgAAAAABAAEAVwAAAK4GAAAAAA==

---1463766271-1139975899-1560744644=:43864--