edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
* [edbrowse-dev] if((c = t.style.color)
@ 2019-06-18  5:16 Kevin Carhart
  2019-06-18  5:50 ` [edbrowse-dev] " Kevin Carhart
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Carhart @ 2019-06-18  5:16 UTC (permalink / raw)
  To: edbrowse-dev


I kept going with maerskline.com and it's complaining about eb$visible

TypeError: cannot read property 'color' of undefined
failure on 0x2228768.eb$visible[]
WINDOW.?

I think some elements are not getting style.color while the test of 
t.style.color expects that they will?   Here is the bp output:

bp: t.style
style object
bp: t.style.color
undefined
bp: t.nodeName
#text

What is #text - a comment?


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [edbrowse-dev] Re: if((c = t.style.color)
  2019-06-18  5:16 [edbrowse-dev] if((c = t.style.color) Kevin Carhart
@ 2019-06-18  5:50 ` Kevin Carhart
  2019-06-18  9:28   ` [edbrowse-dev] " Karl Dahlke
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Carhart @ 2019-06-18  5:50 UTC (permalink / raw)
  To: edbrowse-dev


Actually I misread the error message a little.  If it reports could not 
get color of undefined, that means that the elements do not have a style 
object, not that they don't have a color property.  I echoed nodeType and 
found out that the two elements where this happens are comment and H1. 
For the comment, could we add a style at 
roughly 1380?  As for the H1, I don't know, do these headings get treated 
similar to the paragraph P?  Maybe there is a different solution to this 
altogether.  It can't be happening that often or there would be a lot of 
errors in eb$visible.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [edbrowse-dev] if((c = t.style.color)
  2019-06-18  5:50 ` [edbrowse-dev] " Kevin Carhart
@ 2019-06-18  9:28   ` Karl Dahlke
  2019-06-24  4:06     ` Kevin Carhart
  0 siblings, 1 reply; 4+ messages in thread
From: Karl Dahlke @ 2019-06-18  9:28 UTC (permalink / raw)
  To: edbrowse-dev

> comment and H1.

I can add
this.style = new CSSStyleDeclaration;
at line 1392, which should fix comment.

<h1> has a style object, and createElement("h1") produces an h1 node with a style object.
I have no clue how you found an h1 without style.
You might have to figure out where it came from.
uptrace(h1)
is it from the html or dynamically created?
Is it really h1?

Karl Dahlke

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edbrowse-dev] if((c = t.style.color)
  2019-06-18  9:28   ` [edbrowse-dev] " Karl Dahlke
@ 2019-06-24  4:06     ` Kevin Carhart
  0 siblings, 0 replies; 4+ messages in thread
From: Kevin Carhart @ 2019-06-24  4:06 UTC (permalink / raw)
  To: Karl Dahlke; +Cc: edbrowse-dev


Hi Karl

Thanks for making the .style changes a week ago.  My internet was 
out for some reason and this took a couple of days, but I pulled up 
the elements that didn't have a style object.  Since I immediately 
compiled the latest out of habit, I then had to compile the one from a few 
days ago with this hash:
32c724d109a70ff7b25d95f5367078dd71e353ee#diff-25d902c24283ab8cfbac54dfa101ad31

And here are the uptraces for the two elements.  Maybe it's a moot point 
now since your latest fixed it.  I don't seem to be getting a #text now. 
It happens on a DIV and an H1.


bp: t.style
undefined
bp: uptrace(t)
DIV.carousel__runner
DIV.carousel__slides
DIV.carousel carousel--active carousel--hint
DIV.p-section__brands
DIV.p-page__section__inner
DIV.p-page__section__outer
DIV.p-page__section theme--light--alt
DIV.page p-page
DIV#main
BODY
HTML
DOCUMENT
undefined
bp: .

bp: t.style
undefined
bp: uptrace(t)
H1.font--display-4 typer typer--active typer--complete#anId
DIV.heading
DIV.p-page__header__copy
DIV.p-page__header__col--1
DIV.p-page__header__cell
DIV.p-page__header__table
DIV.p-page__header__content
DIV.p-page__header p-page__header--decision-tree theme--dark#headerDt
DIV.page p-page
DIV#main
BODY
HTML
DOCUMENT
undefined
bp: .






On Tue, 18 Jun 2019, Karl Dahlke wrote:

>> comment and H1.
>
> I can add
> this.style = new CSSStyleDeclaration;
> at line 1392, which should fix comment.
>
> <h1> has a style object, and createElement("h1") produces an h1 node with a style object.
> I have no clue how you found an h1 without style.
> You might have to figure out where it came from.
> uptrace(h1)
> is it from the html or dynamically created?
> Is it really h1?
>
> Karl Dahlke
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-24  4:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18  5:16 [edbrowse-dev] if((c = t.style.color) Kevin Carhart
2019-06-18  5:50 ` [edbrowse-dev] " Kevin Carhart
2019-06-18  9:28   ` [edbrowse-dev] " Karl Dahlke
2019-06-24  4:06     ` Kevin Carhart

edbrowse-dev - development list for edbrowse

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/edbrowse-dev

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 edbrowse-dev edbrowse-dev/ http://inbox.vuxu.org/edbrowse-dev \
		edbrowse-dev@edbrowse.org
	public-inbox-index edbrowse-dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.edbrowse.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git