From: Kevin Carhart <kevin@carhart.net>
To: Karl Dahlke <eklhad@comcast.net>
Cc: edbrowse-dev@lists.the-brannons.com
Subject: Re: [edbrowse-dev] if((c = t.style.color)
Date: Sun, 23 Jun 2019 21:06:03 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1906232052410.153310@carhart.net> (raw)
In-Reply-To: <20190518052843.eklhad@comcast.net>
Hi Karl
Thanks for making the .style changes a week ago. My internet was
out for some reason and this took a couple of days, but I pulled up
the elements that didn't have a style object. Since I immediately
compiled the latest out of habit, I then had to compile the one from a few
days ago with this hash:
32c724d109a70ff7b25d95f5367078dd71e353ee#diff-25d902c24283ab8cfbac54dfa101ad31
And here are the uptraces for the two elements. Maybe it's a moot point
now since your latest fixed it. I don't seem to be getting a #text now.
It happens on a DIV and an H1.
bp: t.style
undefined
bp: uptrace(t)
DIV.carousel__runner
DIV.carousel__slides
DIV.carousel carousel--active carousel--hint
DIV.p-section__brands
DIV.p-page__section__inner
DIV.p-page__section__outer
DIV.p-page__section theme--light--alt
DIV.page p-page
DIV#main
BODY
HTML
DOCUMENT
undefined
bp: .
bp: t.style
undefined
bp: uptrace(t)
H1.font--display-4 typer typer--active typer--complete#anId
DIV.heading
DIV.p-page__header__copy
DIV.p-page__header__col--1
DIV.p-page__header__cell
DIV.p-page__header__table
DIV.p-page__header__content
DIV.p-page__header p-page__header--decision-tree theme--dark#headerDt
DIV.page p-page
DIV#main
BODY
HTML
DOCUMENT
undefined
bp: .
On Tue, 18 Jun 2019, Karl Dahlke wrote:
>> comment and H1.
>
> I can add
> this.style = new CSSStyleDeclaration;
> at line 1392, which should fix comment.
>
> <h1> has a style object, and createElement("h1") produces an h1 node with a style object.
> I have no clue how you found an h1 without style.
> You might have to figure out where it came from.
> uptrace(h1)
> is it from the html or dynamically created?
> Is it really h1?
>
> Karl Dahlke
>
prev parent reply other threads:[~2019-06-24 4:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 5:16 Kevin Carhart
2019-06-18 5:50 ` [edbrowse-dev] " Kevin Carhart
2019-06-18 9:28 ` [edbrowse-dev] " Karl Dahlke
2019-06-24 4:06 ` Kevin Carhart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1906232052410.153310@carhart.net \
--to=kevin@carhart.net \
--cc=edbrowse-dev@lists.the-brannons.com \
--cc=eklhad@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).