From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out.smtp-auth.no-ip.com (smtp-auth.no-ip.com [8.23.224.60]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 0816677B04 for ; Sat, 29 Jun 2019 18:14:30 -0700 (PDT) X-No-IP: carhart.net@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from carhart.net (unknown [99.57.137.251]) (Authenticated sender: carhart.net@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id 99C9637FBBE; Sat, 29 Jun 2019 18:14:30 -0700 (PDT) Received: from localhost (kevin@localhost) by carhart.net (8.15.2/8.15.2) with ESMTP id x5U1ETT9228481; Sat, 29 Jun 2019 18:14:29 -0700 Date: Sat, 29 Jun 2019 18:14:29 -0700 (PDT) From: Kevin Carhart To: Karl Dahlke cc: edbrowse-dev@lists.the-brannons.com Subject: Re: [edbrowse-dev] attributes In-Reply-To: <20190529190858.eklhad@comcast.net> Message-ID: References: <20190529190858.eklhad@comcast.net> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) X-BeenThere: edbrowse-dev@edbrowse.org List-Id: Edbrowse Development List MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Hi Karl Well sure enough.. I was unaware that there was any such distinction, to tell apart an attribute set at create time by createElement, from one that is explicitly set by setAttribute. Ian the acid3 author has a comment right there on 61. You assert that p.hasAttribute('class') must return false, and if it didn't, the diagnostic string says "element had attribute on creation." I assume you're interpreting the acid tests correctly since you pored over the assert() conditions. That would tell you what types of distinctions matter. Maybe there is a JS problem in maersk where it is supposed to be setting id using setAttribute, earlier on. That would be a plausible alternative hypothesis that threads the needle, and returning null would be correct. On Sat, 29 Jun 2019, Karl Dahlke wrote: > I could use your help here. > Line 1680 is there because acid test 17 says that getAttribute of id should not return the id unless it was set by setAttribute, or that is the way I interpreted it at some point. > These various implicitMember functions are suppose to be exceptions, times when you don't getAttribute unless you did an earlier setAttribute. > Same for "class" acid test 61. > Maybe I'm not interpreting the acid tests right, > maybe I just need someone else to take a second look. > > I have acid3 in the github source, it is my version of the original page, but I think it is true to that page, with my comments and changes of course. > > Karl Dahlke >