From: Kevin Carhart <kevin@carhart.net>
To: edbrowse-dev@lists.the-brannons.com
Subject: [edbrowse-dev] resolveURL question
Date: Sun, 30 Jun 2019 20:56:03 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1906302035090.6731@carhart.net> (raw)
Since the change in attributes, the form submit that I was trying on
maersk now works! The result page in self-contained form, is here:
https://www.maersk.com/tracking/#tracking/MRKU7424405
Of course it raised another thing. I noticed a resolution issue with the
hash-mark-and-internal-anchor syntax.
resolveURL currently makes several resolutions of JS files that are in the
page with relative references, like this:
resolve(https://www.maersk.com/tracking/#tracking/MRKU7424405|js/vendor/requirejs/require.js)
= https://www.maersk.com/tracking/#tracking/js/vendor/requirejs/require.js
(require, modernizr, min.js and a CSS file are all done by this logic)
Yet these paths all give 404's because the real structure is like:
https://www.maersk.com/tracking/js/vendor/requirejs/require.js
We then get messages like "CSS suppressed because content type is html"
and the whole thing is not going to work right.
So this is almost but not quite caught by the situation described in the
comment at line 823 of url.c, right?
/* This is an anchor for the current document, don't resolve. */
/* I assume the base does not have a #fragment on the end; that is not
part of the base. */
/* Thus I won't get url#foo#bar */
Do you think the assumption "I assume the base does not have a #fragment
on the end" would also hold for the situation here where it is not at
rel[0] but the last section of base?
next reply other threads:[~2019-07-01 3:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 3:56 Kevin Carhart [this message]
2019-07-01 4:43 ` Karl Dahlke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1906302035090.6731@carhart.net \
--to=kevin@carhart.net \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).