From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out.smtp-auth.no-ip.com (smtp-auth.no-ip.com [8.23.224.60]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 641C677AFD for ; Mon, 1 Jul 2019 21:17:05 -0700 (PDT) X-No-IP: carhart.net@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from carhart.net (unknown [99.57.137.251]) (Authenticated sender: carhart.net@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id 7494F380526 for ; Mon, 1 Jul 2019 21:17:04 -0700 (PDT) Received: from localhost (kevin@localhost) by carhart.net (8.15.2/8.15.2) with ESMTP id x624GxeO022261 for ; Mon, 1 Jul 2019 21:17:00 -0700 Date: Mon, 1 Jul 2019 21:16:59 -0700 (PDT) From: Kevin Carhart To: edbrowse-dev@lists.the-brannons.com Subject: [edbrowse-dev] resolveURL question (fwd) Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) X-BeenThere: edbrowse-dev@edbrowse.org List-Id: Edbrowse Development List MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed I'm glad it was a one character change. I like the way those parseURL arguments for the URL sections are done. I don't think I have spent much time in url.c. It's nice that the phrasing of the "resolve" debugPrints nailed down where the problem was. I thought at first that it might be handleable by one of those Tidy Opt settings. ---------- Forwarded message ---------- Date: Mon, 01 Jul 2019 00:43:43 -0400 From: Karl Dahlke To: edbrowse-dev@lists.the-brannons.com Subject: [edbrowse-dev] resolveURL question resolveURL seems like such a simple routine, but it has been a nightmare for about 15 years now. That's why I have specific debug prints for it, at level 5, probably should be at level 4. We need to see what it is doing and when it screwes up, like here. The section you refer to is not relevant. rel is the variable of the relative piece, and that code is for rel = #foo where I'm just changing the hash. But here we have a new path, and the base has a hash, but the hash contains a slash, which I've never seen before. parseURL handles it properly, so let's step through and see what goes wrong. Line 885 is telling us where the problem is. Fortunately the fix is literally a single character. Karl Dahlke