edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Kevin Carhart <kevin@carhart.net>
To: Adam Thompson <arthompson1990@gmail.com>
Cc: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] [patch] [experimental] JS console patch
Date: Tue, 29 Sep 2015 02:04:55 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LRH.2.03.1509290132090.5825@carhart.net> (raw)
In-Reply-To: <20150929070326.GS2254@toaster.adamthompson.me.uk>



Hi group,

Thanks for pushing the console code and improving it!

Adam and Karl asked:

> How've you done the ok function?
> Is that a piece of js somewhere?

> Wow! First of all, I don't undderstand that javascript at all,
> but I see that it works, so on we go.

Yes, I didn't write that, it's on MDN here,
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys

I brought it in without totally understanding it, but I know one
distinction that they talk about is whether you want to
echo all the methods just on the thing being passed in,
or also on its prototype.

While we're on the subject of what in the world is the
Object.keys code doing, there's another distinction which
may come up some day.  "IsEnumerable" is used in the
function.
Objects can have properties like enumerable,
configurable and writeable. 
It has to do with a permissions idea - I think.
If an object's enumerable is false, I think ok
would return nothing, or is supposed to.
I think it's something to do with protecting
the inaccessibility of private methods.


Kevin






>

--------
Kevin Carhart * 415 225 5306 * The Ten Ninety Nihilists

  reply	other threads:[~2015-09-29  9:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5608d799.c539440a.54033.3b99SMTPIN_ADDED_BROKEN@mx.google.com>
2015-09-29  7:03 ` Adam Thompson
2015-09-29  9:04   ` Kevin Carhart [this message]
2015-09-28  6:00 Kevin Carhart
2015-09-28  9:47 ` Karl Dahlke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.03.1509290132090.5825@carhart.net \
    --to=kevin@carhart.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    --cc=arthompson1990@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).